Logging messages from new defaults only show once per rank. #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Previously, logging messages for the new defaults would be logged by every single dataloader worker per rank. This led to a lot of clutter in run logs. Now, they are only displayed once per rank. Before, logs looked like:
And now, they look like:
![Screenshot 2023-12-18 at 3 21 04 PM](https://private-user-images.githubusercontent.com/28932043/291432980-0fc5319d-827f-406a-b059-e2e5908f6571.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5OTIyNDMsIm5iZiI6MTczOTk5MTk0MywicGF0aCI6Ii8yODkzMjA0My8yOTE0MzI5ODAtMGZjNTMxOWQtODI3Zi00MDZhLWIwNTktZTJlNTkwOGY2NTcxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDE5MDU0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIxMGY1N2ZiZGM2NjgzOTI5NGVlNGUzMjFmMjkwN2Y5YjJhOWUyYzdlNTliYzNiYzViMDg5NWFjNDg2ZmY0ZTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.e3cQqa8xdqgXRkSSmqqU8TqSQzyPPo8c8FO6P8fPYyc)
Issue #, if available:
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)