Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename harness to helpers #715

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix: rename harness to helpers #715

merged 2 commits into from
Jan 15, 2025

Conversation

mahmudsudo
Copy link

closes #701

MathisGD
MathisGD requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires further changes, for example in conf files

QGarchery
QGarchery approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, as verification goes through when I run it locally (this is an issue with CERTORAKEY secret here):
Screenshot from 2025-01-15 10-32-37
Notice how there is one job that is failing, but it's a timeout, and we are already aware of it

MathisGD
MathisGD approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@MathisGD MathisGD merged commit 05be06b into morpho-org:main Jan 15, 2025
5 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@QGarchery QGarchery QGarchery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Certora] harness directory name
3 participants
@mahmudsudo @QGarchery @MathisGD