Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust SSL contexts to use the defaults provided by HomeAssistant #1056

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

firstof9
Copy link
Collaborator

Proposed change

Adjust SSL contexts to use python defaults vs client defaults as defined by HomeAssistant
Reference:
https://github.com/home-assistant/core/blob/22e0b0e9a77918867932135b91400b1bde8edb8b/homeassistant/util/ssl.py#L104-L139

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added the code-quality Improves code quality or adds/updates tests label Jan 21, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.84%. Comparing base (8608d22) to head (1e4be4a).
Report is 62 commits behind head on dev.

Files with missing lines Patch % Lines
custom_components/mail_and_packages/helpers.py 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1056      +/-   ##
==========================================
- Coverage   95.07%   92.84%   -2.23%     
==========================================
  Files           8        9       +1     
  Lines        1482     1650     +168     
==========================================
+ Hits         1409     1532     +123     
- Misses         73      118      +45     
Files with missing lines Coverage Δ
...stom_components/mail_and_packages/binary_sensor.py 100.00% <100.00%> (+2.81%) ⬆️
custom_components/mail_and_packages/helpers.py 92.02% <50.00%> (-2.71%) ⬇️

... and 2 files with indirect coverage changes

@firstof9 firstof9 marked this pull request as ready for review January 21, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Improves code quality or adds/updates tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants