Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stop setting sensors unavailable if IMAP polling fails #1039

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

firstof9
Copy link
Collaborator

Proposed change

Stop setting sensors unavailable when IMAP polling fails.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

  • This PR is related to issue: n/a

@firstof9 firstof9 added code-quality Improves code quality or adds/updates tests work-in-progress labels Dec 19, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (8608d22) to head (a72c269).
Report is 59 commits behind head on dev.

Files with missing lines Patch % Lines
custom_components/mail_and_packages/__init__.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1039      +/-   ##
==========================================
- Coverage   95.07%   92.90%   -2.17%     
==========================================
  Files           8        9       +1     
  Lines        1482     1649     +167     
==========================================
+ Hits         1409     1532     +123     
- Misses         73      117      +44     
Files with missing lines Coverage Δ
...stom_components/mail_and_packages/binary_sensor.py 100.00% <ø> (+2.81%) ⬆️
custom_components/mail_and_packages/camera.py 92.52% <ø> (+3.63%) ⬆️
custom_components/mail_and_packages/const.py 100.00% <100.00%> (ø)
custom_components/mail_and_packages/sensor.py 92.50% <ø> (-0.13%) ⬇️
custom_components/mail_and_packages/__init__.py 84.67% <66.66%> (-7.44%) ⬇️

... and 2 files with indirect coverage changes

@firstof9 firstof9 marked this pull request as ready for review December 19, 2024 17:48
@firstof9 firstof9 merged commit e3d2a88 into moralmunky:dev Dec 19, 2024
5 checks passed
@firstof9 firstof9 deleted the stop-unavailable branch December 19, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Improves code quality or adds/updates tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants