fix: walmart sensors crashing (#811)

* fix: walmart sensors crashing

* update tests

custom_components/mail_and_packages/const.py

@@ -483,7 +483,6 @@
         "subject": ["delivery is delayed"],
     },
     "walmart_tracking": {"patern": ["#[0-9]{7}-[0-9]{7}"]},
-    "walmart_packages": {},
 }
 
 # Sensor definitions
@@ -874,12 +873,6 @@
         icon="mdi:archive-alert",
         key="walmart_exception",
     ),
-    "walmart_packages": SensorEntityDescription(
-        name="Mail Walmart Packages",
-        native_unit_of_measurement="package(s)",
-        icon="mdi:package-variant-closed",
-        key="walmart_packages",
-    ),
     ###
     # !!! Insert new sensors above these two !!!
     ###
@@ -954,5 +947,4 @@
     "bonshaw_distribution_network",
     "purolator",
     "intelcom",
-    "walmart",
 ]

tests/conftest.py

@@ -951,7 +951,6 @@ def mock_update_time():
 def mock_image():
     """Fixture to mock Image."""
     with patch("custom_components.mail_and_packages.helpers.Image") as mock_image:
-
         yield mock_image
 
 
@@ -985,7 +984,6 @@ def mock_resizeimage():
     ) as mock_resizeimage, patch(
         "custom_components.mail_and_packages.helpers.ImageOps"
     ):
-
         yield mock_resizeimage
 
 
@@ -1001,23 +999,20 @@ def mock_os_path_isfile():
 def mock_os_path_join():
     """Fixture to mock join."""
     with patch("os.path.join") as mock_path_join:
-
         yield mock_path_join
 
 
 @pytest.fixture
 def mock_os_path_split():
     """Fixture to mock split."""
     with patch("os.path.split") as mock_os_path_split:
-
         yield mock_os_path_split
 
 
 @pytest.fixture
 def mock_subprocess_call():
     """Fixture to mock subprocess."""
     with patch("subprocess.call") as mock_subprocess_call:
-
         yield mock_subprocess_call
 
 
@@ -1027,7 +1022,6 @@ def mock_copy_overlays():
     with patch(
         "custom_components.mail_and_packages.helpers.copy_overlays"
     ) as mock_copy_overlays:
-
         yield mock_copy_overlays
 
 

tests/const.py

@@ -105,6 +105,8 @@
         "gls_delivered",
         "gls_delivering",
         "gls_packages",
+        "walmart_delivered",
+        "walmart_exception",
     ],
     "scan_interval": 20,
     "username": "[email protected]",
@@ -287,6 +289,8 @@
         "usps_delivering",
         "usps_mail",
         "usps_packages",
+        "walmart_delivered",
+        "walmart_exception",
         "zpackages_delivered",
         "zpackages_transit",
     ],

tests/test_config_flow.py

@@ -155,7 +155,6 @@ async def test_form(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], input_1
         )
@@ -315,7 +314,6 @@ async def test_form_invalid_custom_img_path(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], input_1
         )
@@ -374,7 +372,6 @@ async def test_form_connection_error(input_1, step_id_2, hass, mock_imap):
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], input_1
         )
@@ -502,7 +499,6 @@ async def test_form_invalid_ffmpeg(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], input_1
         )
@@ -645,7 +641,6 @@ async def test_form_index_error(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], input_1
         )
@@ -792,7 +787,6 @@ async def test_form_index_error_2(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], input_1
         )
@@ -938,7 +932,6 @@ async def test_form_mailbox_format2(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], input_1
         )
@@ -1141,7 +1134,6 @@ async def test_options_flow(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], input_1
         )
@@ -1315,7 +1307,6 @@ async def test_options_flow_invalid_custom_img_path(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], input_1
         )
@@ -1389,7 +1380,6 @@ async def test_options_flow_connection_error(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], input_1
         )
@@ -1532,7 +1522,6 @@ async def test_options_flow_invalid_ffmpeg(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], input_1
         )
@@ -1681,7 +1670,6 @@ async def test_options_flow_index_error(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], input_1
         )
@@ -1831,7 +1819,6 @@ async def test_options_flow_index_error_2(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], input_1
         )
@@ -1981,7 +1968,6 @@ async def test_options_flow_mailbox_format2(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], input_1
         )
@@ -2136,7 +2122,6 @@ async def test_options_flow_bad(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], input_1
         )
@@ -2234,7 +2219,6 @@ async def test_form_amazon_error(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], input_1
         )
@@ -2329,7 +2313,6 @@ async def test_form_interval_low(
         "custom_components.mail_and_packages.async_setup_entry",
         return_value=True,
     ) as mock_setup_entry:
-
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], input_1
         )

tests/test_helpers.py

@@ -418,7 +418,7 @@ async def test_image_filename_oserr(
     assert await hass.config_entries.async_setup(entry.entry_id)
     await hass.async_block_till_done()
 
-    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 43
+    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 45
     assert "Problem accessing file:" in caplog.text
 
 
@@ -446,7 +446,7 @@ async def test_image_getctime_oserr(
     assert await hass.config_entries.async_setup(entry.entry_id)
     await hass.async_block_till_done()
 
-    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 43
+    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 45
     assert "Problem accessing file:" in caplog.text
 
 

tests/test_init.py

@@ -29,13 +29,13 @@ async def test_unload_entry(hass, mock_update, mock_copy_overlays):
     assert await hass.config_entries.async_setup(entry.entry_id)
     await hass.async_block_till_done()
 
-    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 43
+    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 45
     entries = hass.config_entries.async_entries(DOMAIN)
     assert len(entries) == 1
 
     assert await hass.config_entries.async_unload(entries[0].entry_id)
     await hass.async_block_till_done()
-    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 43
+    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 45
     assert len(hass.states.async_entity_ids(DOMAIN)) == 0
 
     assert await hass.config_entries.async_remove(entries[0].entry_id)
@@ -67,7 +67,7 @@ async def test_setup_entry(
     assert await hass.config_entries.async_setup(entry.entry_id)
     await hass.async_block_till_done()
 
-    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 43
+    assert len(hass.states.async_entity_ids(SENSOR_DOMAIN)) == 45
     entries = hass.config_entries.async_entries(DOMAIN)
     assert len(entries) == 1
 

tests/test_sensor.py

@@ -8,7 +8,6 @@
 
 @pytest.mark.asyncio
 async def test_sensor(hass, mock_update):
-
     entry = MockConfigEntry(
         domain=DOMAIN,
         title="imap.test.email",