Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Upload build not just on releases #8

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rotu
Copy link

@rotu rotu commented Nov 22, 2023

Upload built plugin. This is to ease testing of unreleased plugins.
The intent is to make this available for other proto plugins, but you gotta start somewhere.

@rotu
Copy link
Author

rotu commented Nov 22, 2023

Related to: moonrepo/proto#296 (comment)
Ideally, this can be consumable directly from proto with something like `plugins.python = "source:https://github.com/rotu/moonrepo-python-plugin/suites/18399993921/artifacts/1066037821".

alternatives:

  • upload as artifact
    • 👎 Artifact links like https://github.com/rotu/moonrepo-python-plugin/suites/18399993921/artifacts/1066037821 returns 307 Temporary Redirect.
    • 👎 Artifacts are always compressed in zip, so there is no direct link to the wasm
  • check the wasm into git (optionally with git LFS)
    • 👍 This fits the node convention of attaching a dist folder to the repo
    • 👎 This fits the node convention of high-churn files checked in to source and requires either hooks or rewriting history to ensure consistency.
  • create a release on push (esp. a prerelease)
    • 👍 This provides a direct link to the artifact

@rotu rotu marked this pull request as draft November 22, 2023 06:32
@rotu rotu changed the title upload build as artifact Upload build not just on releases Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant