Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option for creating custom resolutions #1349

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added option for creating custom resolutions #1349

wants to merge 3 commits into from

Conversation

MaurilhoB
Copy link

Added an option for users to create their own custom resolutions in the desired aspect ratio. If the user has a phone with a 20:9 aspect ratio and a resolution of 2400x1080, they could scale it down to 1920x864 and still have full screen utilization.

I had this problem with my native resolution not being supported by the decoder, so I made this adjustment to enable full screen utilization simply by downscaling the resolution.

@quangmach
Copy link

Please merge this to master. This custom resolution has been requested for few years already. Thank you!

@MuhamadRifkii MuhamadRifkii mentioned this pull request May 6, 2024
Open
@zhoumother
Copy link

太感谢了

@kajdo
Copy link

kajdo commented May 11, 2024

I would love to see this becoming part of the official repo

@heloess
Copy link

heloess commented May 29, 2024

I can't thank you enough

@kaizendevsio
Copy link

kaizendevsio commented Jun 21, 2024 •
edited
Loading

@cgutman please merge this to master when you have time, i love moonlight but this holds back a lot of people :)

@bshaoulian
Copy link

This would be a fantastic addition to the master repo

@danielmartina
Copy link

danielmartina commented Aug 13, 2024 •
edited
Loading

Tested it as well on my device and it is a really useful functionality. It would be worth to merge it. Thank you Maurilho!

@survivor182ca
Copy link

Yes, please merge it because on samsung dex on my ultrawide monitor (3440x1440) i can t use on moonlight that resolution.

My only choice are 2560x1440 or 4k resolution

Thank in advance for your good work.😀

@ReenigneArcher
Copy link
Contributor

@LuisB79 I am not a maintainer here, but my guess is that it needs to be reviewed and properly tested.

ReenigneArcher
ReenigneArcher reviewed Oct 29, 2024
View reviewed changes
app/src/main/java/com/limelight/preferences/StreamSettings.java
import com.limelight.utils.Dialog;
import com.limelight.utils.UiHelper;

import java.lang.reflect.Method;
import java.util.Arrays;
import java.util.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know wildcard imports are used in a few other places, but I'm not sure it's a good practice.

app/src/main/java/com/limelight/preferences/CustomResolutionsPreference.java
Comment on lines +15 to +18
import android.widget.*;
import com.limelight.R;

import java.util.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

app/src/main/res/drawable/ic_delete.xml
<path
android:fillColor="#FFFFFF"
android:pathData="M17.114,3.923h-4.589V2.427c0-0.252-0.207-0.459-0.46-0.459H7.935c-0.252,0-0.459,0.207-0.459,0.459v1.496h-4.59c-0.252,0-0.459,0.205-0.459,0.459c0,0.252,0.207,0.459,0.459,0.459h1.51v12.732c0,0.252,0.207,0.459,0.459,0.459h10.29c0.254,0,0.459-0.207,0.459-0.459V4.841h1.511c0.252,0,0.459-0.207,0.459-0.459C17.573,4.127,17.366,3.923,17.114,3.923M8.394,2.886h3.214v0.918H8.394V2.886z M14.686,17.114H5.314V4.841h9.372V17.114z M12.525,7.306v7.344c0,0.252-0.207,0.459-0.46,0.459s-0.458-0.207-0.458-0.459V7.306c0-0.254,0.205-0.459,0.458-0.459S12.525,7.051,12.525,7.306M8.394,7.306v7.344c0,0.252-0.207,0.459-0.459,0.459s-0.459-0.207-0.459-0.459V7.306c0-0.254,0.207-0.459,0.459-0.459S8.394,7.051,8.394,7.306"/>
</vector>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</vector>
</vector>

Probably a good practice to have an empty blank line at the end of each file.

@timharry timharry mentioned this pull request Nov 3, 2024
Open
@Steso871
Copy link

Steso871 commented Nov 13, 2024 •
edited
Loading

Added an option for users to create their own custom resolutions in the desired aspect ratio. If the user has a phone with a 20:9 aspect ratio and a resolution of 2400x1080, they could scale it down to 1920x864 and still have full screen utilization.

I had this problem with my native resolution not being supported by the decoder, so I made this adjustment to enable full screen utilization simply by downscaling the resolution.

Is this version available somewhere? Would love to try it on my tab a9+ that is refusing to use native resolution

@alphain24
Copy link

any updates on this?

@alphain24
Copy link

Sadly not.

Everyone I ask begins to talk about a9+ isn't capable and it's demanding but that is just wrong and they don't know what they are talking about.

Using a moonlight version with custom resolution support for now @alphain24

yeah its unfortunate.....i really want to get my hands on a moonlight version with custom resolution support cause that would be so useful

@Steso871
Copy link

Steso871 commented Dec 22, 2024 via email •
edited
Loading

@alphain24
Copy link

I just tested it out with 1920x864 and it seems to be working perfectly!! Finally!!!!

@Steso871
Copy link

I just tested it out with 1920x864 and it seems to be working perfectly!! Finally!!!!

Glad to hear! :) would be nice to be able to use 90hz too..

Bought this tablet for that reason because I gave my s6 lite away..

Would be good too have a dev look at our issue if it's moonlight or Samsungs issue

@alphain24
Copy link

90Hz seems to be working on my device! no issues what so ever...you have use the virtual display driver and give it the 90hz refresh rate!! Works flawless

@Steso871
Copy link

90Hz seems to be working on my device! no issues what so ever...you have use the virtual display driver and give it the 90hz refresh rate!! Works flawless

What os do you use and can you choose 90 in fps menu in moonlight? If you turn on stats it shows

@alphain24
Copy link

so i basically use my phone and it has a 90hz display so it just shows me the 90hz option in moonlight and the os i use is xiomi...i tested with apple as well and the ios app seems to have the custom resolution feature already. but yes i have the 90fps in the menu in moonlight. you might have to turn on 90hz on your display first in your settings

@Steso871
Copy link

Steso871 commented Dec 22, 2024 via email

@alphain24
Copy link

you might want to switch to 90hz if possible if you cant im sure there are ways to achieve it but once you get 90hz on the display itself and you select 90hz on moonlight...you wont get the error -5

@Steso871
Copy link

Steso871 commented Dec 22, 2024 via email

@alphain24
Copy link

something is definitely messed up then....you might need to do some tests and what not to figure out the solution

@Steso871
Copy link

Steso871 commented Dec 22, 2024 via email

@alphain24
Copy link

what resolution are you using on your host?

@Steso871
Copy link

Steso871 commented Dec 22, 2024 via email

@alphain24
Copy link

download the beta version of virtual display driver and you can add a custom resolution like 1680x1050

there is a video from mike the tech on this and just make sure that you use that resolution on the display driver. then i believe you should have no issues

https://www.youtube.com/watch?v=tyC9h0IbqsQ&t=176s&pp=ygUbdmlydHVhbCBkaXNwbGF5IGRyaXZlciBiZXRh

@Steso871
Copy link

Steso871 commented Dec 22, 2024 via email

@alphain24
Copy link

ahh i see thats true but maybe try it once? who knows it might fix it

@Steso871
Copy link

Steso871 commented Dec 22, 2024 via email

@alphain24
Copy link

i see! im not sure what the issue is then?

@Steso871
Copy link

Steso871 commented Dec 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.