Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ♻️ Update repo to use biome #844

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

timbrinded
Copy link
Contributor

@timbrinded timbrinded commented Feb 4, 2025

Warning

There is a very high number of files changes as a result of the change of linting. The github preview is slow as a result

High Level Changes

  • Update the tanssi repo to use biome.js to replace both eslint and prettier.
    • Not only is this faster to run, but is easier to maintain and more modern/better supported code. This reduces some of our tech debt and finds some common linting gotchas
  • Fix the 1000+ linting issues on existing test files (typescript tech debt)
  • Re-index test case IDs since we have many duplicates
  • Add types to helpers (not exhaustive though)
  • Update Package Versions

Copy link
Contributor

github-actions bot commented Feb 4, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1416 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2168 KB (no changes) ✅

container chain template simple runtime: 1116 KB (no changes) ✅

container chain template frontier runtime: 1404 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Coverage Report

(master)

@@                   Coverage Diff                    @@
##           master   refactor/switch-biome     +/-   ##
========================================================
  Coverage   66.04%                  66.04%   0.00%     
  Files         335                     335             
  Lines       58850                   58850             
========================================================
  Hits        38866                   38866             
  Misses      19984                   19984             
Files Changed Coverage

Coverage generated Wed Feb 5 15:12:29 UTC 2025

@timbrinded timbrinded added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code labels Feb 4, 2025
@timbrinded timbrinded marked this pull request as ready for review February 5, 2025 16:15
@timbrinded timbrinded requested review from a team February 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants