Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reward processor in snowbridge inbound queue #8

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Add reward processor in snowbridge inbound queue #8

merged 4 commits into from
Feb 10, 2025
+77 −51

Conversation

dimartiro
Copy link

@dimartiro dimartiro commented Feb 5, 2025 •
edited
Loading

Description

Introduce reward processor to add more flexibility in order to reward the relayer from the snowbridge inbound queue messages

  • New trait RewardProcessor with process_reward func
  • Mocks
  • Fix tests

@dimartiro dimartiro force-pushed the diego-snowbridge-inbound-queue-reward-processor branch from 01ec45f to d10c05a Compare February 5, 2025 13:50
@dimartiro dimartiro force-pushed the diego-snowbridge-inbound-queue-reward-processor branch from d10c05a to 52b86b4 Compare February 5, 2025 13:52
@dimartiro dimartiro marked this pull request as ready for review February 5, 2025 13:53
@dimartiro dimartiro requested a review from girazoki February 5, 2025 14:44
girazoki
girazoki approved these changes Feb 6, 2025
View reviewed changes
Copy link

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @dimartiro but make sure ALL tests pass please

@dimartiro
Copy link
Author

Looks good @dimartiro but make sure ALL tests pass please

Sure! you mean the inbound-queue crate tests or all the polkadot-sdk tests?

@girazoki
Copy link

girazoki commented Feb 6, 2025

If you can polkadot-sdk tests as well. I am not sure to which extenet our branch is compatible with them though

@girazoki girazoki requested a review from ParthDesai February 6, 2025 16:32
@github-actions github-actions bot requested a review from girazoki February 6, 2025 18:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Review required! Latest push from author must always be reviewed

@dimartiro
Copy link
Author

If you can polkadot-sdk tests as well. I am not sure to which extenet our branch is compatible with them though

There are a lot of issues if I want to run the tests for the entire repo but so far the inbound-queue tests are passing ok

image

@dimartiro
Copy link
Author

dimartiro commented Feb 10, 2025 •
edited
Loading

@girazoki these are the errors I mentioned that are preventing me to run the tests from the root folder using cargo test

image

Perhaps I'm doing something wrong, let me know if that's the case.

Similar issues trying to run the tests in tanssi-polkadot-stable2409 branch

@dimartiro dimartiro merged commit 0e6fe98 into tanssi-polkadot-stable2409 Feb 10, 2025
42 of 67 checks passed
@dimartiro dimartiro mentioned this pull request Feb 12, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki approved these changes

@ParthDesai ParthDesai Awaiting requested review from ParthDesai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimartiro @girazoki @ParthDesai