Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-297401: Handle x509 just like other project resources #2084

Merged
merged 4 commits into from
Feb 6, 2025
Merged

CLOUDP-297401: Handle x509 just like other project resources #2084

merged 4 commits into from
Feb 6, 2025
+109 −24

Conversation

igor-karpukhin
Copy link
Collaborator

All Submissions:

Handle x509 just like other project resources

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

@igor-karpukhin igor-karpukhin added the cloud-tests Run expensive Cloud Tests: Integration & E2E label Feb 3, 2025
s-urbaniak
s-urbaniak approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests failed but generally LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/c983b3ef69bf714daefc913e43d7c8f43bd5350b

@igor-karpukhin igor-karpukhin merged commit 1bf3bf9 into main Feb 6, 2025
60 of 66 checks passed
@igor-karpukhin igor-karpukhin deleted the CLOUDP-297401/x509-handler branch February 6, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helderjs helderjs helderjs approved these changes

@s-urbaniak s-urbaniak s-urbaniak approved these changes

@josvazg josvazg josvazg approved these changes

Assignees
No one assigned
Labels
cloud-tests Run expensive Cloud Tests: Integration & E2E
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igor-karpukhin @helderjs @s-urbaniak @josvazg