Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-280012: Add http dry run transport for Atlas #2026

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

s-urbaniak
Copy link
Collaborator

This adds a dry run transport towards Atlas calls. Note that this contribution is a no-op for now. The operator starts in non-dry-run mode.

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

Copy link
Collaborator

@roothorp roothorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just to clarify my understanding of the feature; this is going to be used to we can create all of the Atlas API calls we would make, but without actually sending them, letting us preview what a change would do?

internal/controller/atlas/provider.go Show resolved Hide resolved
internal/controller/atlas/provider.go Show resolved Hide resolved
@s-urbaniak s-urbaniak merged commit 6320166 into main Jan 10, 2025
57 checks passed
@s-urbaniak s-urbaniak deleted the dry-run-impl branch January 10, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants