Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test cleanup to prevent conflicts between tests. #1608

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin requested a review from jyemin January 15, 2025 20:25
@vbabanin vbabanin self-assigned this Jan 15, 2025
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but wondering whether ClientSideEncryptionExternalKeyVaultTest should also do some cleanup, e.g. drop the collection.

@vbabanin vbabanin requested a review from jyemin January 15, 2025 20:43
@vbabanin vbabanin requested a review from jyemin January 15, 2025 20:52
@jyemin
Copy link
Collaborator

jyemin commented Jan 18, 2025

Let me know why the collection name change had to be reverted.

@vbabanin
Copy link
Member Author

Let me know why the collection name change had to be reverted.

Initially, the calculation of bytes to be subtracted from the available bytes for the message in the batch-splitting test was defined as 1122 in the spec tests. After changing the namespace, the test started failing. I reverted the change but later found a way to recalculate it. The test and namespace have now been updated accordingly.

@vbabanin vbabanin requested a review from jyemin January 18, 2025 23:21
@vbabanin vbabanin merged commit 51c736e into mongodb:main Jan 21, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants