Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for parsing Aggregates.sort stage INTELLIJ-127 #97

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

himanshusinghs
Copy link
Contributor

@himanshusinghs himanshusinghs commented Nov 22, 2024

Description

Includes:

  • Parsing of $sort built with Aggregates.sort, limited to, as defined in scope:
    • Sorts.ascending
    • Sorts.descending
    • Sorts.orderBy
  • Autocomplete support for fields in Sorts.ascending, Sorts.exclude and Sorts.orderBy
  • Linter inspections for field existence and type checks in Sorts

I noticed that we were not parsing incomplete match calls so added that here as well (eac0239)

Checklist

Open Questions

@github-actions github-actions bot added the feature Adds a new feature. label Nov 22, 2024
Copy link

Coverage Report

Overall Project 77.95% -0.06%
Files changed 93.21%

File Coverage
HasSorts.kt 100%
Named.kt 99.43%
JavaDriverDialectParser.kt 88.11% -0.68%

@himanshusinghs himanshusinghs merged commit 2e8d11c into main Nov 22, 2024
12 of 13 checks passed
@himanshusinghs himanshusinghs deleted the feat/INTELLIJ-127-aggregates-sort-stage branch November 22, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants