Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename HasFieldReference.(Known to FromSchema) and introduce HasChildren interface INTELLIJ-125 #89

Merged
merged 7 commits into from
Nov 18, 2024
Merged

chore: rename HasFieldReference.(Known to FromSchema) and introduce HasChildren interface INTELLIJ-125 #89

merged 7 commits into from
Nov 18, 2024

Conversation

himanshusinghs
Copy link
Contributor

@himanshusinghs himanshusinghs commented Nov 11, 2024 •
edited
Loading

Description

Just pulling out the refactor that is harmless (rename of FieldReference.Known to FieldReference.FromSchema) and touches multiple files. Part of work required in INTELLIJ-125

Checklist

Open Questions

@github-actions github-actions bot added the no release notes It's a chore and doesn't require release notes. label Nov 11, 2024
@himanshusinghs himanshusinghs added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 11, 2024
@himanshusinghs himanshusinghs changed the title chore: rename HasFieldReference.(Known to FromSchema) and introduce HasChildren interface chore: rename HasFieldReference.(Known to FromSchema) and introduce HasChildren interface INTELLIJ-125 Nov 11, 2024
@himanshusinghs himanshusinghs removed the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Coverage Report

Overall Project 77.07% -0.16% ✅
Files changed 72.19% ✅

File Coverage
HasUpdates.kt 100% ✅
HasFilter.kt 100% ✅
FieldCheckingLinter.kt 98.74% ✅
Node.kt 97.94% ✅
HasValueReference.kt 94.44% ✅
HasFieldReference.kt 94% -6% ✅
IndexAnalyzer.kt 91.18% ✅
SpringCriteriaDialectParser.kt 87.38% ✅
JavaDriverDialectParser.kt 84.24% ✅
MongoshDialectFormatter.kt 80.46% -3.22% 🚫
HasFieldReference.kt 35.42% ✅
SpringAtQueryDialectParser.kt 31.03% -1.18% 🚫

@himanshusinghs himanshusinghs changed the base branch from main to fix/find-one-parsing November 13, 2024 16:14
Base automatically changed from fix/find-one-parsing to main November 14, 2024 12:48
@kmruiz kmruiz self-requested a review November 14, 2024 14:39
@himanshusinghs himanshusinghs merged commit 107e2d9 into main Nov 18, 2024
12 checks passed
@himanshusinghs himanshusinghs deleted the chore/minor-refactor branch November 18, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmruiz kmruiz kmruiz approved these changes

Assignees
No one assigned
Labels
no release notes It's a chore and doesn't require release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshusinghs @kmruiz