Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: instead of running the whole pipeline again, only allow drafts when main is green already #55

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

kmruiz
Copy link
Contributor

@kmruiz kmruiz commented Sep 16, 2024

Description

Checklist

Open Questions

@kmruiz kmruiz added fix Fixes a bug. no release notes It's a chore and doesn't require release notes. labels Sep 16, 2024
@kmruiz kmruiz self-assigned this Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

Coverage Report

Overall Project 87.83%

There is no coverage information present for the Files changed

@himanshusinghs
Copy link
Contributor

I think its a good idea but there is one thing this might miss, last minute dependency problem creeps (we saw that being quite common in compass repo). Something we should be aware of.

@kmruiz
Copy link
Contributor Author

kmruiz commented Sep 23, 2024

We are using fixed versions, it shouldn't happen right?

@himanshusinghs
Copy link
Contributor

himanshusinghs commented Sep 23, 2024

Yea so I wanted to mention that our fixed version might get identified for a vuln at some point?

@kmruiz
Copy link
Contributor Author

kmruiz commented Sep 23, 2024

Ah true, this might happen for sure. So what we can do is, whenever we generate the SBOM (we are not doing it yet but it's planned), do it also before releasing and after checking main is green. So we don't need to run the whole suite but we verify that our deps don't have any important CVE.

@himanshusinghs
Copy link
Contributor

That sounds like a plan 👍

@kmruiz kmruiz merged commit 3833ed0 into main Sep 23, 2024
12 checks passed
@kmruiz kmruiz deleted the ci/run-only-draft-if-checks-are-successful branch September 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug. no release notes It's a chore and doesn't require release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants