feat: add support for parsing, inspecting and autocompleting in a group stage written using Spring Data MongoDB INTELLIJ-175 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supported operators include: - sum - avg - first - last - max - min - push - addToSet
himanshusinghs
commented
Jan 24, 2025
Comment on lines
-816
to
-846
| private fun parseComputedExpression(element: PsiElement): HasValueReference<PsiElement> { | ||
| val (constant, value) = element.tryToResolveAsConstant() | ||
| return HasValueReference( | ||
| when { | ||
| constant && value is String -> HasValueReference.Computed( | ||
| element, | ||
| type = ComputedBsonType( | ||
| BsonAny, | ||
| Node( | ||
| element, | ||
| listOf( | ||
| HasFieldReference( | ||
| FromSchema(element, value.trim('$'), value) | ||
| ) | ||
| ) | ||
| ) | ||
| ) | ||
| ) | ||
| constant -> HasValueReference.Constant( | ||
| element, | ||
| value, | ||
| value?.javaClass.toBsonType(value) | ||
| ) | ||
| !constant && element is PsiExpression -> HasValueReference.Runtime( | ||
| element, | ||
| element.type?.toBsonType() ?: BsonAny | ||
| ) | ||
| else -> HasValueReference.Unknown as HasValueReference.ValueReference<PsiElement> | ||
| } | ||
| ) | ||
| } |
There was a problem hiding this comment.
I needed this method so I pulled it out of class and put it as an extension method on PsiElement, down below in the file.
| methodCall.argumentList.expressions.toList() | ||
| } else { | ||
| val fieldsObjectExpression = methodCall.argumentList.expressions.getOrNull(0) | ||
| fieldsObjectExpression?.resolveFieldStringExpressionsFromFieldsObject() ?: emptyList() |
There was a problem hiding this comment.
This is a method that I am reusing from ProjectStageParser. That was originally a private method but I pulled it out as an extension method to support this.
Comment on lines
-72
to
-82
| private fun fieldObjectExpressionToProjectedFieldNode( | ||
| fieldObjectExpression: PsiExpression, | ||
| projectionName: Name | ||
| ): Node<PsiElement>? { | ||
| val fieldExpression = fieldObjectExpression.resolveFieldStringExpressionFromFieldObject() | ||
| ?: return null | ||
| return createProjectedFieldNode( | ||
| fieldExpression = fieldExpression, | ||
| projectionName = projectionName | ||
| ) | ||
| } |
There was a problem hiding this comment.
This entire method was not needed after refactor so I removed it.
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This entire logic is shifted down below as extension method
Coverage Report
|
|
🤖 Benchmark Comparison for
|
|
🤖 Benchmark Comparison for
|
kmruiz
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for parsing, inspecting and autocompleting in a group stage written using
Aggregation.groupand chainedGroupOperations usingsum,avg,first,last,max,min,pushandaddToSet.Checklist
Open Questions