feat(query-generation): support for the unwind stages INTELLIJ-195 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmruiz
commented
Jan 23, 2025
| is FromSchema -> registerConstant(ref.fieldName) | ||
| is Inferred<S> -> registerConstant(ref.fieldName) | ||
| is HasFieldReference.Computed<S> -> registerConstant(ref.fieldName) | ||
| is FromSchema -> registerConstant(ref.displayName) |
There was a problem hiding this comment.
Changed to use displayName because fieldName removes any prefixed '$' in the field, and in unwind it's mandatory. Because displayName holds the information "as the user wrote it" makes sense to use it here. We were using fieldName because this part was done before displayName was introduced.
Coverage Report
|
|
🤖 Benchmark Comparison for
|
|
🤖 Benchmark Comparison for
|
himanshusinghs
approved these changes
Jan 23, 2025
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ MongoDB plugin for IntelliJ IDEA. | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| * [INTELLIJ-195](https://jira.mongodb.org/browse/INTELLIJ-195) Add support for $unwind. | |||
There was a problem hiding this comment.
Sorry I did not notice this before but I guess we wanna be a little more precise about what support we added for this and the other item?
There was a problem hiding this comment.
sounds good, let me just make another commit making this more precise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Open Questions