-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spring): add support for the unwind aggregation stage INTELLIJ-176 #120
Conversation
Coverage Report
|
🤖 Benchmark Comparison for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the parser test, maybe we should extend our current inspection and autocomplete test to also check for cases in unwind.
override fun isSuitableForFieldAutoComplete( | ||
methodCall: PsiMethodCallExpression, | ||
method: PsiMethod | ||
) = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the method name is a little confusing but the idea of this method isSuitableForFieldAutoComplete
is for parsers to check and confirm, based on their understanding, if the provided method call is a good target for autocompleter to add field autocomplete.
So it will most likely have the same logic as canParse but might also differ (for example it does differ in project parser). In this case, I think we can safely defer to canParse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool, I'll fix it then! I think eventually we will need to add more information to this method then, because not all arguments in a method call expression are suitable for autocomplete. But this is something we can do later.
Description
Checklist
Open Questions