-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for parsing, inspecting and autocompleting in an aggregation and a match stage written using Spring Data MongoDB INTELLIJ-172 #116
Conversation
Coverage Report
|
🤖 Benchmark Comparison for
|
- covers field check inspections and namespace check inspection
🤖 Benchmark Comparison for
|
🤖 Benchmark Comparison for
|
🤖 Benchmark Comparison for
|
} | ||
} | ||
|
||
@Disabled("We do not yet support criteria referenced as a variable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are such cases which I found that we did not support yet but we do support similar in JavaDriverDialectParser. If it makes sense then I will drop a ticket for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think it makes sense to create a ticket for this. I'm not sure we will need to tackle this soon, but let's wait to our testers to decide :D.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created INTELLIJ-184 for addressing the missing cases.
- covers both aggregate and aggregate stream calls - additionally extended the isCollectionReference logic to also account for collection reference inside aggregate and aggregateStream calls
🤖 Benchmark Comparison for
|
🤖 Benchmark Comparison for
|
🤖 Benchmark Comparison for
|
} | ||
} | ||
|
||
@Disabled("We do not yet support criteria referenced as a variable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think it makes sense to create a ticket for this. I'm not sure we will need to tackle this soon, but let's wait to our testers to decide :D.
Description
Adds support for parsing, inspecting and autocompleting in an aggregation written using Spring Data MongoDB. The PR mainly focuses on parsing the common syntax for writing an aggregation, using
MongoTemplate.aggregate
andMongoTemplate.aggregateStream
and a match stage written with Aggregation.match.Checklist
Open Questions