chore: fixes docker install step and failing build info test #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
no release notes
himanshusinghs
added
the
no-title-validation
Coverage Report
|
himanshusinghs
changed the title
|
🤖 Benchmark Comparison for
|
kmruiz
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like the installation target is either removed or renamed and we can't install docker just with the name docker. I am using the recommended steps in Docker's install documentation to set up the install step.
For the failing test, I changed from strict version comparison to a loose comparison using
String.startsWith. This should remove the work of keeping this number updated across different releases of mongodb server.Checklist
Open Questions