Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filters.(and/or/nor) not working with iterable arguments for Java Driver dialect INTELLIJ-157 #111

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

himanshusinghs
Copy link
Contributor

Description

The key change is just around using PsiMethodCallExpression.getVarArgsOrIterableArgs() for resolving correct arguments, the rest of the changes are just specific tests that I added for better coverage.

Checklist

Open Questions

@github-actions github-actions bot added the fix Fixes a bug. label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Coverage Report

Overall Project 78.32%
Files changed 100%

File Coverage
JavaDriverDialectParser.kt 88.26%

@github-actions github-actions bot added fix Fixes a bug. and removed fix Fixes a bug. labels Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

🤖 Benchmark Comparison for Merge branch 'main' into fix/INTELLIJ-157

Benchmark Previous Current Change
com.mongodb.jbplugin.jmh.SampleBenchmark.init 2,634,476,841.29 ops/s 2,675,184,442.15 ops/s 1.55%

@himanshusinghs himanshusinghs added the no release notes It's a chore and doesn't require release notes. label Jan 7, 2025
@github-actions github-actions bot added fix Fixes a bug. and removed fix Fixes a bug. no release notes It's a chore and doesn't require release notes. labels Jan 7, 2025
@github-actions github-actions bot added fix Fixes a bug. and removed fix Fixes a bug. labels Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

🤖 Benchmark Comparison for chore: added CHANGELOG entry

Benchmark Previous Current Change
com.mongodb.jbplugin.jmh.SampleBenchmark.init 2,664,355,353.95 ops/s 2,611,148,528.99 ops/s -2.00%

@himanshusinghs himanshusinghs merged commit 596fc5e into main Jan 8, 2025
11 checks passed
@himanshusinghs himanshusinghs deleted the fix/INTELLIJ-157 branch January 8, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants