Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix the changelog check #106

Merged
merged 4 commits into from
Jan 7, 2025
Merged

chore(ci): fix the changelog check #106

merged 4 commits into from
Jan 7, 2025

Conversation

nirinchev
Copy link
Contributor

@nirinchev nirinchev commented Nov 28, 2024

Description

The previous check was incorrect - it was never actually running because the step name was invalid. I've moved it to a dedicated workflow because we need different triggers for the check to work correctly (e.g. it wouldn't pick up manually adding a label, because that would not trigger the workflow). I've also simplified some of the logic as we were using quite a few steps before which could be combined into a single one.

Checklist

Open Questions

@github-actions github-actions bot added the no release notes It's a chore and doesn't require release notes. label Nov 28, 2024
@nirinchev nirinchev added no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) no release notes It's a chore and doesn't require release notes. and removed no release notes It's a chore and doesn't require release notes. labels Nov 28, 2024
Copy link

github-actions bot commented Nov 29, 2024

Coverage Report

There is no coverage information present for the Files changed

@nirinchev nirinchev removed the no release notes It's a chore and doesn't require release notes. label Nov 29, 2024
Copy link

🤖 Benchmark Comparison for Don't enforce changelog for merge commits

Benchmark Previous Current Change
com.mongodb.jbplugin.jmh.SampleBenchmark.init 2,499,964,015.59 ops/s 2,633,858,863.01 ops/s 5.36%

@github-actions github-actions bot added the no release notes It's a chore and doesn't require release notes. label Nov 29, 2024
@nirinchev nirinchev added no release notes It's a chore and doesn't require release notes. and removed no release notes It's a chore and doesn't require release notes. labels Nov 29, 2024
@github-actions github-actions bot added no release notes It's a chore and doesn't require release notes. and removed no release notes It's a chore and doesn't require release notes. labels Nov 29, 2024
Copy link

🤖 Benchmark Comparison for Move changelog enforcement to a dedicated workflow

Benchmark Previous Current Change
com.mongodb.jbplugin.jmh.SampleBenchmark.init 2,499,964,015.59 ops/s 2,630,951,379.72 ops/s 5.24%

Copy link
Contributor

@himanshusinghs himanshusinghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up, looks good 🚀

@nirinchev nirinchev merged commit 5159908 into main Jan 7, 2025
13 of 17 checks passed
@nirinchev nirinchev deleted the ni/changelog-action branch January 7, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release notes It's a chore and doesn't require release notes. no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants