-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): fix the changelog check #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
no release notes
It's a chore and doesn't require release notes.
label
Nov 28, 2024
nirinchev
added
no-title-validation
Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
no release notes
It's a chore and doesn't require release notes.
and removed
no release notes
It's a chore and doesn't require release notes.
labels
Nov 28, 2024
Coverage Report
|
nirinchev
removed
the
no release notes
It's a chore and doesn't require release notes.
label
Nov 29, 2024
🤖 Benchmark Comparison for
|
github-actions
bot
added
the
no release notes
It's a chore and doesn't require release notes.
label
Nov 29, 2024
nirinchev
added
no release notes
It's a chore and doesn't require release notes.
and removed
no release notes
It's a chore and doesn't require release notes.
labels
Nov 29, 2024
github-actions
bot
added
no release notes
It's a chore and doesn't require release notes.
and removed
no release notes
It's a chore and doesn't require release notes.
labels
Nov 29, 2024
🤖 Benchmark Comparison for
|
himanshusinghs
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this up, looks good 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no release notes
It's a chore and doesn't require release notes.
no-title-validation
Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous check was incorrect - it was never actually running because the step name was invalid. I've moved it to a dedicated workflow because we need different triggers for the check to work correctly (e.g. it wouldn't pick up manually adding a label, because that would not trigger the workflow). I've also simplified some of the logic as we were using quite a few steps before which could be combined into a single one.
Checklist
Open Questions