chore: tests and minor suggestions for INTELLIJ-128 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshusinghs
commented
Nov 25, 2024
...src/main/kotlin/com/mongodb/jbplugin/dialects/javadriver/glossary/JavaDriverDialectParser.kt
Show resolved
Hide resolved
| val (constant, value) = element.tryToResolveAsConstant() | ||
| return HasValueReference( | ||
| when { | ||
| constant && value is String -> HasValueReference.Computed( | ||
| element, | ||
| type = ComputedBsonType( | ||
| BsonAny, | ||
| BsonString, |
There was a problem hiding this comment.
This is the same suggestion as in the original PR
There was a problem hiding this comment.
Ah yes, I remember answering there. The thing is that while how we define the expression is a string, the type of the value is not a string right? For example "$year" is not a string, is an int32, so using a string here is not accurate. I feel that until we can infer the type of the expression, we should just assume any. WDYT?
There was a problem hiding this comment.
keeping BsonAny here because the actual type is not relevant for now, will revert this particular change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Open Questions