chore: fix tests

mongodb · Nov 6, 2024 · 89f8af2 · 89f8af2
1 parent 7cb8a70
commit 89f8af2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/.../kotlin/com/mongodb/jbplugin/inspections/impl/JavaDriverFieldCheckLinterInspectionTest.kt b/.../kotlin/com/mongodb/jbplugin/inspections/impl/JavaDriverFieldCheckLinterInspectionTest.kt
@@ -16,7 +16,6 @@ import org.mockito.kotlin.any
 import org.mockito.kotlin.eq
 
 @CodeInsightTest
-@Suppress("TOO_LONG_FUNCTION", "LONG_LINE")
 class JavaDriverFieldCheckLinterInspectionTest {
     @ParsingTest(
         fileName = "Repository.java",
@@ -86,7 +85,9 @@ public class Repository {
         `when`(
             readModelProvider.slice(eq(dataSource), any<GetCollectionSchema.Slice>())
         ).thenReturn(
-            GetCollectionSchema(CollectionSchema(Namespace("", ""), BsonObject(emptyMap()))),
+            GetCollectionSchema(
+                CollectionSchema(Namespace("myDatabase", "myCollection"), BsonObject(emptyMap()))
+            ),
         )
 
         fixture.enableInspections(FieldCheckInspectionBridge::class.java)
@@ -129,7 +130,7 @@ public class Repository {
         ).thenReturn(
             GetCollectionSchema(
                 CollectionSchema(
-                    Namespace("", ""),
+                    Namespace("myDatabase", "myCollection"),
                     BsonObject(mapOf("thisIsDouble" to BsonDouble))
                 )
             ),

diff --git a/...lin/com/mongodb/jbplugin/inspections/impl/SpringCriteriaFieldCheckLinterInspectionTest.kt b/...lin/com/mongodb/jbplugin/inspections/impl/SpringCriteriaFieldCheckLinterInspectionTest.kt
@@ -124,7 +124,9 @@ class BookRepository {
         `when`(
             readModelProvider.slice(eq(dataSource), any<GetCollectionSchema.Slice>())
         ).thenReturn(
-            GetCollectionSchema(CollectionSchema(Namespace("", ""), BsonObject(emptyMap()))),
+            GetCollectionSchema(
+                CollectionSchema(Namespace("sample_mflix", "book"), BsonObject(emptyMap()))
+            ),
         )
 
         application.withMockedService(dbConnectionManager)
@@ -203,7 +205,9 @@ class BookRepository {
         `when`(
             readModelProvider.slice(eq(dataSource), any<GetCollectionSchema.Slice>())
         ).thenReturn(
-            GetCollectionSchema(CollectionSchema(Namespace("", ""), BsonObject(emptyMap()))),
+            GetCollectionSchema(
+                CollectionSchema(Namespace("bad_db", "book"), BsonObject(emptyMap()))
+            ),
         )
 
         application.withMockedService(dbConnectionManager)

diff --git a/...ongodb-linting-engine/src/main/kotlin/com/mongodb/jbplugin/linting/FieldCheckingLinter.kt b/...ongodb-linting-engine/src/main/kotlin/com/mongodb/jbplugin/linting/FieldCheckingLinter.kt
@@ -150,7 +150,7 @@ object FieldCheckingLinter {
     ): FieldCheckWarning<S>? {
         val fieldType = collectionSchema.typeOf(pair.first.fieldName)
         val fieldName = pair.first.fieldName
-        val valueSource = pair.first.source
+        val valueSource = pair.second.first
         val valueType = pair.second.second
 
         return FieldCheckWarning.FieldValueTypeMismatch(