DOCSP-44904 Shorten TOC Labels #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ltran-mdb2
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Thanks for this work @lindseymoore ! I left a couple comments and questions for your consideration.
Comment on lines
31
to
32
| .. /connect/network-compression | ||
| .. /connect/server-selection |
There was a problem hiding this comment.
Can we add labels to these as well?
There was a problem hiding this comment.
These are pages that haven't been created yet, so not necessary! @ltran-mdb2
| Replace </write/replace> | ||
| Delete </write/delete> | ||
| Bulk Write </write/bulk-write> | ||
| Transactions </write/transactions> | ||
|
|
||
| .. | ||
| /write/gridfs |
There was a problem hiding this comment.
Same as above
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
* DOCSP-44904 Shorten TOC Labels * Lauren suggestion (cherry picked from commit fe5d9f8)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v5.1 v5.1
# Navigate to the new working tree
cd .worktrees/backport-v5.1
# Create a new branch
git switch --create backport-55-to-v5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fe5d9f8d39c9d1bda64018888dc4dd33e3caa656
# Push it to GitHub
git push --set-upstream origin backport-55-to-v5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v5.1Then, create a pull request where the |
lindseymoore
added a commit
that referenced
this pull request
Nov 22, 2024
* DOCSP-44904 Shorten TOC Labels * Lauren suggestion (cherry picked from commit fe5d9f8) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
to lindseymoore/docs-kotlin-sync
that referenced
this pull request
Nov 22, 2024
* DOCSP-44904 Shorten TOC Labels * Lauren suggestion (cherry picked from commit fe5d9f8)
lindseymoore
added a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44904
Staging - https://deploy-preview-55--docs-kotlin-sync.netlify.app/
Self-Review Checklist