DOCSP-42607: v5.2 changes #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
norareidy
approved these changes
Sep 24, 2024
| to the expected types in BSON. | ||
|
|
||
| In the following example, the driver serializes the fields of |
There was a problem hiding this comment.
S: [nit] Since this sentence repeats "following", you could reword to just "this example":
Suggested change
| In the following example, the driver serializes the fields of | |
| In this example, the driver serializes the fields of |
|
|
||
| The following example inserts an instance of the ``Appointment`` data | ||
| class into MongoDB: |
There was a problem hiding this comment.
S: you can be more specific about where you're inserting data
Suggested change
| class into MongoDB: | |
| class into a MongoDB collection named "appointments": |
|
|
||
| In MongoDB, the ``LocalDate`` value is stored as a BSON date, and the | ||
| ``time`` field is stored as a string by default serialization: |
There was a problem hiding this comment.
S: remove extra space
Suggested change
| ``time`` field is stored as a string by default serialization: | |
| ``time`` field is stored as a string by default serialization: |
| @@ -66,7 +72,8 @@ The following code example shows how to create an Atlas Search index: | |||
| :end-before: end-create-search-index | |||
| :dedent: | |||
|
|
|||
| The following code example shows how to create multiple indexes: | |||
| The following code example shows how to create Search and | |||
There was a problem hiding this comment.
S:
Suggested change
| The following code example shows how to create Search and | |
| The following code example shows how to create Atlas Search and |
| pre-filter your data. | ||
|
|
||
| You can call the following methods on a collection to manage your Atlas | ||
| Search and Vector Search indexes: | ||
|
|
||
| - ``createSearchIndex()`` | ||
| - ``createSearchIndexes()`` |
There was a problem hiding this comment.
Q: Does the note below (can't comment on it directly) apply just to Atlas Search indexes? If it applies to Vector search index methods as well, I'd update it to reflect that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42607
Staging:
Self-Review Checklist