DOCSP-42813: codecs #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for docs-kotlin-sync pending review.Visit the deploys page to approve it
|
stephmarie17
approved these changes
Aug 22, 2024
source/data-formats/codecs.txt
Outdated
| * - Parameter Type | ||
| - Description | ||
|
|
||
| * - ``bsonReader`` |
There was a problem hiding this comment.
[question] Should this be reader similar to the writer parameter in the previous table? I noticed reader is in the example and in the API doc but not specifically described in this table.
source/data-formats/codecs.txt
Outdated
| enum values to BSON booleans. | ||
|
|
||
| - ``colorTemperature``: Describes the color of the device light in | ||
| Kelvins as an ``Int`` value. For this field, use the ``IntegerCodec`` |
There was a problem hiding this comment.
[nit] I think this is usually singular if capitalized, or lowercase when plural:
Suggested change
| Kelvins as an ``Int`` value. For this field, use the ``IntegerCodec`` | |
| kelvins as an ``Int`` value. For this field, use the ``IntegerCodec`` |
or
Suggested change
| Kelvins as an ``Int`` value. For this field, use the ``IntegerCodec`` | |
| Kelvin as an ``Int`` value. For this field, use the ``IntegerCodec`` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42813
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kotlin-sync/DOCSP-42813-codecs/data-formats/codecs/
Self-Review Checklist