Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-41128: delete docs #17

Merged
merged 5 commits into from
Jul 23, 2024
Merged

DOCSP-41128: delete docs #17

merged 5 commits into from
Jul 23, 2024

Conversation

rustagir
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41128
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kotlin-sync/DOCSP-41128-delete/write/delete/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST? unrelated
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Jul 22, 2024 •
edited
Loading

👷 Deploy request for docs-kotlin-sync pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d229efd

@rustagir rustagir marked this pull request as ready for review July 22, 2024 21:29
mcmorisi
mcmorisi approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@mcmorisi mcmorisi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Few things, but I don't think any of them are blocking. LGTM overall!

source/write/delete.txt Outdated Show resolved Hide resolved
source/write/delete.txt Outdated Show resolved Hide resolved
source/write/delete.txt Outdated Show resolved Hide resolved
source/write/delete.txt Show resolved Hide resolved
source/includes/write/delete.kt Outdated Show resolved Hide resolved
@rustagir rustagir requested a review from rozza July 23, 2024 14:06
rozza
rozza approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustagir rustagir merged commit 6dda8ff into mongodb:master Jul 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmorisi mcmorisi mcmorisi approved these changes

@rozza rozza rozza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustagir @rozza @mcmorisi