-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-43962) [Kafka] Kafka connector nested components #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kafka-connector ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
carriecwk
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor nits.
source/source-connector/configuration-properties/kafka-topic.txt
Outdated
Show resolved
Hide resolved
source/source-connector/configuration-properties/kafka-topic.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: carriecwk <[email protected]>
Co-authored-by: carriecwk <[email protected]>
elyse-mdb
added a commit
to elyse-mdb/docs-kafka-connector
that referenced
this pull request
Oct 4, 2024
* (DOCSP-43962) Unnested 1 example in tip. * (DOCSP-43962) Removing the subjunctive should * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Typo fix. * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Unnested 1 tip in table. * (DOCSP-42962) Fixing indentation error and unnesting 1 important admonition in table. * (DOCSP-42962) Spacing. * (DOCSP-42962) Build errors. * (DOCSP-42962) Unnested 1 example and 1 note in table. * (DOCSP-42962) Unnested 2 examples and 1 note in include. * (DOCSP-42962) Replace quotation marks with monospace. * (DOCSP-42962) Unnested 2 notes in table. * (DOCSP-42962) consistency. * (DOCSP-42962) Edited for consistency and unnested 2 tips. * (DOCSP-42962) Removing extra line breaks. * (DOCSP-42962) Unnested 2 important admonitions in table. * (DOCSP-42962) Fix rendering error. * (DOCSP-42962) Fixing rendering issues. * (DOCSP-42962) Unnested 2 notes and 1 example in table. * (DOCSP-42962) Unnested 3 important admonitions * (DOCSP-42962) Spacing fix. * (DOCSP-42962) Unnested 1 example and 3 tips. * (DOCSP-42962) Unnested 1 note, 2 tips, 1 important admonition. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing and adding reference to the Data Formats page. * (DOCSP-42962) Unnested 3 tips, 1 example and 1 important admonition in table. * (DOCSP-42962) Regularizing usage of pipeline operator line breaks. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing across pages. * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> --------- Co-authored-by: Elyse Foreman <[email protected]> Co-authored-by: carriecwk <[email protected]>
elyse-mdb
added a commit
to elyse-mdb/docs-kafka-connector
that referenced
this pull request
Oct 4, 2024
* (DOCSP-43962) Unnested 1 example in tip. * (DOCSP-43962) Removing the subjunctive should * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Typo fix. * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Unnested 1 tip in table. * (DOCSP-42962) Fixing indentation error and unnesting 1 important admonition in table. * (DOCSP-42962) Spacing. * (DOCSP-42962) Build errors. * (DOCSP-42962) Unnested 1 example and 1 note in table. * (DOCSP-42962) Unnested 2 examples and 1 note in include. * (DOCSP-42962) Replace quotation marks with monospace. * (DOCSP-42962) Unnested 2 notes in table. * (DOCSP-42962) consistency. * (DOCSP-42962) Edited for consistency and unnested 2 tips. * (DOCSP-42962) Removing extra line breaks. * (DOCSP-42962) Unnested 2 important admonitions in table. * (DOCSP-42962) Fix rendering error. * (DOCSP-42962) Fixing rendering issues. * (DOCSP-42962) Unnested 2 notes and 1 example in table. * (DOCSP-42962) Unnested 3 important admonitions * (DOCSP-42962) Spacing fix. * (DOCSP-42962) Unnested 1 example and 3 tips. * (DOCSP-42962) Unnested 1 note, 2 tips, 1 important admonition. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing and adding reference to the Data Formats page. * (DOCSP-42962) Unnested 3 tips, 1 example and 1 important admonition in table. * (DOCSP-42962) Regularizing usage of pipeline operator line breaks. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing across pages. * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> --------- Co-authored-by: Elyse Foreman <[email protected]> Co-authored-by: carriecwk <[email protected]>
elyse-mdb
added a commit
that referenced
this pull request
Oct 4, 2024
* (DOCSP-43962) [Kafka] Kafka connector nested components (#167) * (DOCSP-43962) Unnested 1 example in tip. * (DOCSP-43962) Removing the subjunctive should * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Typo fix. * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Unnested 1 tip in table. * (DOCSP-42962) Fixing indentation error and unnesting 1 important admonition in table. * (DOCSP-42962) Spacing. * (DOCSP-42962) Build errors. * (DOCSP-42962) Unnested 1 example and 1 note in table. * (DOCSP-42962) Unnested 2 examples and 1 note in include. * (DOCSP-42962) Replace quotation marks with monospace. * (DOCSP-42962) Unnested 2 notes in table. * (DOCSP-42962) consistency. * (DOCSP-42962) Edited for consistency and unnested 2 tips. * (DOCSP-42962) Removing extra line breaks. * (DOCSP-42962) Unnested 2 important admonitions in table. * (DOCSP-42962) Fix rendering error. * (DOCSP-42962) Fixing rendering issues. * (DOCSP-42962) Unnested 2 notes and 1 example in table. * (DOCSP-42962) Unnested 3 important admonitions * (DOCSP-42962) Spacing fix. * (DOCSP-42962) Unnested 1 example and 3 tips. * (DOCSP-42962) Unnested 1 note, 2 tips, 1 important admonition. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing and adding reference to the Data Formats page. * (DOCSP-42962) Unnested 3 tips, 1 example and 1 important admonition in table. * (DOCSP-42962) Regularizing usage of pipeline operator line breaks. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing across pages. * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> --------- Co-authored-by: Elyse Foreman <[email protected]> Co-authored-by: carriecwk <[email protected]> * (DOCSP-42962-v110-backport) Build error fix. --------- Co-authored-by: carriecwk <[email protected]> Co-authored-by: your proper name <your github email>
elyse-mdb
added a commit
that referenced
this pull request
Oct 4, 2024
* (DOCSP-43962) Unnested 1 example in tip. * (DOCSP-43962) Removing the subjunctive should * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Typo fix. * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Unnested 1 tip in table. * (DOCSP-42962) Fixing indentation error and unnesting 1 important admonition in table. * (DOCSP-42962) Spacing. * (DOCSP-42962) Build errors. * (DOCSP-42962) Unnested 1 example and 1 note in table. * (DOCSP-42962) Unnested 2 examples and 1 note in include. * (DOCSP-42962) Replace quotation marks with monospace. * (DOCSP-42962) Unnested 2 notes in table. * (DOCSP-42962) consistency. * (DOCSP-42962) Edited for consistency and unnested 2 tips. * (DOCSP-42962) Removing extra line breaks. * (DOCSP-42962) Unnested 2 important admonitions in table. * (DOCSP-42962) Fix rendering error. * (DOCSP-42962) Fixing rendering issues. * (DOCSP-42962) Unnested 2 notes and 1 example in table. * (DOCSP-42962) Unnested 3 important admonitions * (DOCSP-42962) Spacing fix. * (DOCSP-42962) Unnested 1 example and 3 tips. * (DOCSP-42962) Unnested 1 note, 2 tips, 1 important admonition. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing and adding reference to the Data Formats page. * (DOCSP-42962) Unnested 3 tips, 1 example and 1 important admonition in table. * (DOCSP-42962) Regularizing usage of pipeline operator line breaks. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing across pages. * Update source/source-connector/configuration-properties/kafka-topic.txt * Update source/source-connector/configuration-properties/kafka-topic.txt --------- Co-authored-by: carriecwk <[email protected]>
elyse-mdb
added a commit
to elyse-mdb/docs-kafka-connector
that referenced
this pull request
Oct 4, 2024
* (DOCSP-43962) Unnested 1 example in tip. * (DOCSP-43962) Removing the subjunctive should * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Typo fix. * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Unnested 1 tip in table. * (DOCSP-42962) Fixing indentation error and unnesting 1 important admonition in table. * (DOCSP-42962) Spacing. * (DOCSP-42962) Build errors. * (DOCSP-42962) Unnested 1 example and 1 note in table. * (DOCSP-42962) Unnested 2 examples and 1 note in include. * (DOCSP-42962) Replace quotation marks with monospace. * (DOCSP-42962) Unnested 2 notes in table. * (DOCSP-42962) consistency. * (DOCSP-42962) Edited for consistency and unnested 2 tips. * (DOCSP-42962) Removing extra line breaks. * (DOCSP-42962) Unnested 2 important admonitions in table. * (DOCSP-42962) Fix rendering error. * (DOCSP-42962) Fixing rendering issues. * (DOCSP-42962) Unnested 2 notes and 1 example in table. * (DOCSP-42962) Unnested 3 important admonitions * (DOCSP-42962) Spacing fix. * (DOCSP-42962) Unnested 1 example and 3 tips. * (DOCSP-42962) Unnested 1 note, 2 tips, 1 important admonition. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing and adding reference to the Data Formats page. * (DOCSP-42962) Unnested 3 tips, 1 example and 1 important admonition in table. * (DOCSP-42962) Regularizing usage of pipeline operator line breaks. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing across pages. * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> --------- Co-authored-by: Elyse Foreman <[email protected]> Co-authored-by: carriecwk <[email protected]>
elyse-mdb
added a commit
to elyse-mdb/docs-kafka-connector
that referenced
this pull request
Oct 4, 2024
* (DOCSP-43962) Unnested 1 example in tip. * (DOCSP-43962) Removing the subjunctive should * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Typo fix. * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Unnested 1 tip in table. * (DOCSP-42962) Fixing indentation error and unnesting 1 important admonition in table. * (DOCSP-42962) Spacing. * (DOCSP-42962) Build errors. * (DOCSP-42962) Unnested 1 example and 1 note in table. * (DOCSP-42962) Unnested 2 examples and 1 note in include. * (DOCSP-42962) Replace quotation marks with monospace. * (DOCSP-42962) Unnested 2 notes in table. * (DOCSP-42962) consistency. * (DOCSP-42962) Edited for consistency and unnested 2 tips. * (DOCSP-42962) Removing extra line breaks. * (DOCSP-42962) Unnested 2 important admonitions in table. * (DOCSP-42962) Fix rendering error. * (DOCSP-42962) Fixing rendering issues. * (DOCSP-42962) Unnested 2 notes and 1 example in table. * (DOCSP-42962) Unnested 3 important admonitions * (DOCSP-42962) Spacing fix. * (DOCSP-42962) Unnested 1 example and 3 tips. * (DOCSP-42962) Unnested 1 note, 2 tips, 1 important admonition. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing and adding reference to the Data Formats page. * (DOCSP-42962) Unnested 3 tips, 1 example and 1 important admonition in table. * (DOCSP-42962) Regularizing usage of pipeline operator line breaks. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing across pages. * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> * Update source/source-connector/configuration-properties/kafka-topic.txt Co-authored-by: carriecwk <[email protected]> --------- Co-authored-by: Elyse Foreman <[email protected]> Co-authored-by: carriecwk <[email protected]>
elyse-mdb
added a commit
that referenced
this pull request
Oct 4, 2024
* (DOCSP-43962) Unnested 1 example in tip. * (DOCSP-43962) Removing the subjunctive should * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Typo fix. * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Unnested 1 tip in table. * (DOCSP-42962) Fixing indentation error and unnesting 1 important admonition in table. * (DOCSP-42962) Spacing. * (DOCSP-42962) Build errors. * (DOCSP-42962) Unnested 1 example and 1 note in table. * (DOCSP-42962) Unnested 2 examples and 1 note in include. * (DOCSP-42962) Replace quotation marks with monospace. * (DOCSP-42962) Unnested 2 notes in table. * (DOCSP-42962) consistency. * (DOCSP-42962) Edited for consistency and unnested 2 tips. * (DOCSP-42962) Removing extra line breaks. * (DOCSP-42962) Unnested 2 important admonitions in table. * (DOCSP-42962) Fix rendering error. * (DOCSP-42962) Fixing rendering issues. * (DOCSP-42962) Unnested 2 notes and 1 example in table. * (DOCSP-42962) Unnested 3 important admonitions * (DOCSP-42962) Spacing fix. * (DOCSP-42962) Unnested 1 example and 3 tips. * (DOCSP-42962) Unnested 1 note, 2 tips, 1 important admonition. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing and adding reference to the Data Formats page. * (DOCSP-42962) Unnested 3 tips, 1 example and 1 important admonition in table. * (DOCSP-42962) Regularizing usage of pipeline operator line breaks. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing across pages. * Update source/source-connector/configuration-properties/kafka-topic.txt * Update source/source-connector/configuration-properties/kafka-topic.txt --------- Co-authored-by: carriecwk <[email protected]>
elyse-mdb
added a commit
that referenced
this pull request
Oct 4, 2024
* (DOCSP-43962) Unnested 1 example in tip. * (DOCSP-43962) Removing the subjunctive should * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Typo fix. * (DOCSP-42962) Unnested 1 important admonition in table. * (DOCSP-42962) Unnested 1 tip in table. * (DOCSP-42962) Fixing indentation error and unnesting 1 important admonition in table. * (DOCSP-42962) Spacing. * (DOCSP-42962) Build errors. * (DOCSP-42962) Unnested 1 example and 1 note in table. * (DOCSP-42962) Unnested 2 examples and 1 note in include. * (DOCSP-42962) Replace quotation marks with monospace. * (DOCSP-42962) Unnested 2 notes in table. * (DOCSP-42962) consistency. * (DOCSP-42962) Edited for consistency and unnested 2 tips. * (DOCSP-42962) Removing extra line breaks. * (DOCSP-42962) Unnested 2 important admonitions in table. * (DOCSP-42962) Fix rendering error. * (DOCSP-42962) Fixing rendering issues. * (DOCSP-42962) Unnested 2 notes and 1 example in table. * (DOCSP-42962) Unnested 3 important admonitions * (DOCSP-42962) Spacing fix. * (DOCSP-42962) Unnested 1 example and 3 tips. * (DOCSP-42962) Unnested 1 note, 2 tips, 1 important admonition. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing and adding reference to the Data Formats page. * (DOCSP-42962) Unnested 3 tips, 1 example and 1 important admonition in table. * (DOCSP-42962) Regularizing usage of pipeline operator line breaks. * (DOCSP-42962) Spacing. * (DOCSP-42962) Spacing. * (DOCSP-42962) Normalizing spacing across pages. * Update source/source-connector/configuration-properties/kafka-topic.txt * Update source/source-connector/configuration-properties/kafka-topic.txt --------- Co-authored-by: carriecwk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unnesting components in 18 Kafka Connector pages.
This spreadsheet tracks the number of nested components on each page, and this doc provides guidelines for fixing nested components.
PR Reviewing Guidelines
DOCSP-42962
STAGING
important
admonition in table.important
admonition in table include.important
admonitions in table.important
admonitions.important
admonition.Self-Review Checklist