DOCSP-34887: v1.11.1 release #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-smith721
approved these changes
Dec 11, 2023
source/whats-new.txt
Outdated
| both the connector side and the server side . | ||
|
|
||
| Version 1.9 introduced a bug related to ``MongoSourceTask.start`` that can cause a resource leak on | ||
| both the connector side and the server side . |
There was a problem hiding this comment.
Suggested change
| both the connector side and the server side . | |
| both the connector side and the server side. |
source/whats-new.txt
Outdated
| What's New in 1.11.1 | ||
| -------------------- | ||
|
|
||
| - Fixed wildcard matching for partial field name matching. To learn more about |
There was a problem hiding this comment.
S: The wording of this first sentence is a little confusing to, but possibly because I don't know these features well. Would it make sense to say something like this to avoid the repeated " matching" phrase:
Suggested change
| - Fixed wildcard matching for partial field name matching. To learn more about | |
| - Fixed partial name matching with wildcards. To learn more about |
There was a problem hiding this comment.
I think the "with" association makes it less clear how wildcards are associated with partial name matching.
Maybe "Fixed wildcard matching on partial field names in documents." could make this more clear without repeating "matching"?
ccho-mongodb
pushed a commit
that referenced
this pull request
Dec 11, 2023
* DOCSP-34887: v1.11.1 release (cherry picked from commit cf381ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-34887
Staging - https://preview-mongodbcchomongodb.gatsbyjs.io/kafka-connector/DOCSP-34887-v1.11.1/whats-new/#std-label-kafka-connector-whats-new-1.11.1
Self-Review Checklist