-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
45af927
commit 3882e4c
Showing
2 changed files
with
66 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,27 @@ | ||
## Pull Request Info | ||
|
||
[PR Reviewing Guidelines](https://github.com/10gen/docs-kafka-connector/blob/master/REVIEWING.md) | ||
|
||
### Issue JIRA link: | ||
https://jira.mongodb.org/browse/DOCSP-NNNN | ||
https://jira.mongodb.org/browse/DOCSP-NNNNN | ||
|
||
### Snooty build log: | ||
**Paste your workerpool job link here** | ||
|
||
### Docs staging link (requires sign-in on MongoDB Corp SSO): | ||
https://docs-mongodborg-staging.corp.mongodb.com/NNNNNNN/java/docsworker-xlarge/NNNNNNNNNNN/ | ||
https://docs-mongodborg-staging.corp.mongodb.com/NNNNNNN/node/docsworker-xlarge/NNNNNNNNNNN/ | ||
|
||
### Self-Review Checklist | ||
|
||
- [ ] Is this free of any warnings or errors in the RST? | ||
- [ ] Did you run a spell-check? | ||
- [ ] Did you run a grammar-check? | ||
- [ ] Does it render on staging correctly? | ||
- [ ] Are all the links working? | ||
- [ ] Are the staging and workerpool job links in the PR description updated? | ||
|
||
### If your page documents a concept, does it meet the following criteria? | ||
|
||
- [ ] Target the [Jasmin persona](https://drive.google.com/file/d/14FbBOLCVxwSP6M9BK4Nz1Ir9tzxT8_02/view) | ||
- [ ] Target the [Lucas persona](https://drive.google.com/file/d/1J2vqJxo7ldv7OP_obA9Q-avf0o_ju4Lk/view) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# Pull Request Reviewing Guidelines for Kafka Connector Documentation | ||
|
||
Contributions to the set of documents in this repository can receive reviews from one or both of the following types of reviews: | ||
|
||
1. A **copy review**, which focuses on information structure and wording; typically performed by a MongoDB Documentation Team member | ||
2. A **technical review**, which addresses code snippets and the technical correctness of prose; typically performed by a MongoDB engineer. | ||
|
||
See the following sections for reviewer expectations for each type of pull request (PR) review: | ||
|
||
## Copy Review | ||
|
||
Review the structure, wording, and flow of the information in the PR, and correct it if necessary. | ||
|
||
### What to Review | ||
|
||
- Wording | ||
- Page structure | ||
- Technical content to the extent of the reviewer’s understanding. | ||
- Whether the PR fulfills the Acceptance Criteria described in the | ||
linked JIRA ticket. | ||
|
||
### What Not to Review | ||
|
||
Nothing is completely off-limits to a copy review of a PR -- if you notice a technical issue, it's best to call it out early. | ||
Copy reviewers should constrain their reviews to content within the scope of the JIRA ticket, or otherwise create PRs to address anything unrelated. | ||
|
||
|
||
## Technical Review | ||
|
||
Review the technical accuracy and completeness of a PR and correct it if necessary. | ||
|
||
### What to Review | ||
|
||
- Code snippets; ensure the code is idiomatic and that all technical claims are correct. e.g. ("To create a `Foo`, use the `Bar.createFoo()` method") | ||
- Problematic explanations that could trip up users who try to follow the documentation. | ||
|
||
### What Not to Review | ||
|
||
While we welcome any recommendations on wording and structure, avoid blocking approval based on any copy edits. Please entrust the author to make the writing decisions based on style guidelines and team-specific writing conventions, and to create PRs to address anything they deem outside the technical review scope. | ||
|
||
- Wording of sentences, although corrections to technical claims are welcome | ||
- Structure of the page | ||
- Any unchanged lines outside the PR unless relevant to the ticket acceptance criteria. | ||
|