Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REP-5358 Add additional retryer updates. #78

Merged
merged 19 commits into from
Dec 11, 2024
Merged

REP-5358 Add additional retryer updates. #78

merged 19 commits into from
Dec 11, 2024

Conversation

FGasper
Copy link
Collaborator

@FGasper FGasper commented Dec 9, 2024

PR #76 missed some changes due to differences between repositories. This changeset restores those:

  • NoteSuccess() now requires a description of what succeeded, which will go into the log.
  • The retryer logs context cancellation errors at debug level.
  • A few more data points go into the logs now.

@FGasper FGasper requested a review from tdq45gj December 10, 2024 14:35
@FGasper FGasper marked this pull request as ready for review December 10, 2024 15:36
tdq45gj
tdq45gj approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@tdq45gj tdq45gj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FGasper FGasper merged commit 19ad17a into mongodb-labs:main Dec 11, 2024
49 checks passed
@FGasper FGasper deleted the REP-5358-add-retry-description branch December 11, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdq45gj tdq45gj tdq45gj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FGasper @tdq45gj