Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of 'kill' arguments in killport function. #577

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

matthewdale
Copy link
Contributor

The versions of kill on the platforms we commonly use (Ubuntu, RHEL, macOS) expect the -SIGKILL flag to come before the PID arguments.

Ubuntu

$ kill "1234567890" -SIGKILL
-bash: kill: (1234567890) - No such process
-bash: kill: -SIGKILL: arguments must be process or job IDs

With -SIGKILL first:

$ kill -SIGKILL "1234567890"
-bash: kill: (1234567890) - No such process

RHEL

$ kill "1234567890" -SIGKILL
-bash: kill: (1234567890) - No such process
-bash: kill: -SIGKILL: arguments must be process or job IDs

With -SIGKILL first:

$ kill -SIGKILL "1234567890"
-bash: kill: (1234567890) - No such process

macos

kill "1234567890" -SIGKILL
kill: kill 1234567890 failed: no such process
kill: illegal pid: -SIGKILL

With -SIGKILL first:

kill -SIGKILL "1234567890"
kill: kill 1234567890 failed: no such process

@matthewdale matthewdale requested a review from blink1073 January 13, 2025 23:34
@matthewdale matthewdale merged commit d8098d2 into mongodb-labs:master Jan 17, 2025
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants