Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2328 Add more explicit AWS test instructions #375

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

blink1073
Copy link
Member

Also remove an unused top level script. It was temporarily used in PyMongo.

@blink1073 blink1073 requested a review from NoahStapp November 29, 2023 15:18
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these docs intended for local development or explaining the structure our EG code uses?

@blink1073
Copy link
Member Author

Are these docs intended for local development or explaining the structure our EG code uses?

Good point, I added a note

@blink1073 blink1073 requested a review from NoahStapp November 29, 2023 17:28
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment for clarity, otherwise looks good!

```

It is recommended that these actions be broken into scripts that can be run locally as well as in CI. The instructions
Copy link
Contributor

@NoahStapp NoahStapp Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have these broken up into scripts? If so, we could link to them here as an example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not, no, that is part of a broader effort and what the EVG docs recommend.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth opening a ticket to track that work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073 blink1073 requested a review from NoahStapp November 29, 2023 18:30
@blink1073 blink1073 merged commit a78135a into mongodb-labs:master Nov 29, 2023
12 checks passed
@blink1073 blink1073 deleted the DRIVERS-2328-2 branch November 29, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants