remove unnecessary $convert in ObjectIdAutoField $lookup queries

mongodb-labs · Oct 28, 2024 · 221a282 · 221a282
1 parent d12ed39
commit 221a282
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/django_mongodb/fields/auto.py b/django_mongodb/fields/auto.py
@@ -34,6 +34,9 @@ def get_prep_value(self, value):
     def db_type(self, connection):
         return "objectId"
 
+    def rel_db_type(self, connection):
+        return "objectId"
+
     def to_python(self, value):
         if value is None or isinstance(value, int):
             return value

diff --git a/tests/queries_/test_mql.py b/tests/queries_/test_mql.py
@@ -18,9 +18,9 @@ def test_join(self):
             query,
             "db.queries__book.aggregate(["
             "{'$lookup': {'from': 'queries__author', "
-            "'let': {'parent__field__0': {'$convert': {'input': '$author_id', 'to': 'string'}}}, "
-            "'pipeline': [{'$match': {'$expr': {'$and': [{'$eq': ['$$parent__field__0', "
-            "{'$convert': {'input': '$_id', 'to': 'string'}}]}]}}}], 'as': 'queries__author'}}, "
+            "'let': {'parent__field__0': '$author_id'}, "
+            "'pipeline': [{'$match': {'$expr': "
+            "{'$and': [{'$eq': ['$$parent__field__0', '$_id']}]}}}], 'as': 'queries__author'}}, "
             "{'$unwind': '$queries__author'}, "
             "{'$match': {'$expr': {'$eq': ['$queries__author.name', 'Bob']}}}])",
         )