ci(NODE-6570): Test on all supported platforms and Node versions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
docker-support
branch
2 times, most recently
from
0fb3260 to
6172e8d
Compare
baileympearson
force-pushed
the
docker-support
branch
from
8b1b9e6 to
5e9ab8e
Compare
baileympearson
changed the title
baileympearson
commented
Nov 21, 2024
| @@ -1,7 +1,7 @@ | |||
| #ifndef MONGODB_ZSTD_COMPRESSION | |||
| #define MONGODB_ZSTD_COMPRESSION | |||
|
|
|||
| #include <exception> | |||
| #include <stdexcept> | |||
There was a problem hiding this comment.
This was actually the wrong include.
baileympearson
commented
Nov 21, 2024
| @@ -0,0 +1,46 @@ | |||
| #! /bin/bash | |||
|
|
|||
| # script to aid in local testing of linux platforms | |||
There was a problem hiding this comment.
Happy to remove, but this is a handy script to run our tests locally in linux containers.
baileympearson
commented
Nov 21, 2024
| describe('old compress, new decompress', testSuite(decompress, zstdLegacy.compress)); | ||
| describe('new compress, new decompress', testSuite(decompress, compress)); | ||
| let zstdLegacy; | ||
| try { |
There was a problem hiding this comment.
[email protected] does not have s390x builds.
durran
added
the
Primary Review
durran
requested changes
Nov 21, 2024
durran
approved these changes
Nov 21, 2024
durran
added
Team Review
durran
added
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Expands the testing matrix to all supported platforms, architectures and node versions.
As mentioned today at standup, Node18+ alpine arm64 builds are skipped. They will be addressed in https://jira.mongodb.org/browse/NODE-6575.
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run format:js && npm run format:rsscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript