chore: modernize repository #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
approved these changes
Aug 7, 2024
himanshusinghs
requested changes
Aug 7, 2024
himanshusinghs
approved these changes
Aug 7, 2024
addaleax
added a commit
to mongodb-js/devtools-shared
that referenced
this pull request
Aug 7, 2024
PR with changes to the fork was at mongodb-js/socksv5#1
3 tasks
addaleax
added a commit
to mongodb-js/devtools-shared
that referenced
this pull request
Aug 7, 2024
PR with changes to the fork was at mongodb-js/socksv5#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to make sure we can keep using the
socksv5package. This is already based on the heroku fork ofsocksv5, and I'd plan on making the first few commits here part of a pull request to their fork (as a "take it or leave it" kind of thing – it's probably as unmaintained as the original package).Whether this is enough for us to close https://jira.mongodb.org/browse/COMPASS-5472 or not, I'm not sure, but honestly I'd lean towards saying it is.
I've tried to keep changes somewhat minimal (i.e. no style fixes and no integration into devtools-shared) so that we can abandon this fork if at some point something better comes up.
chore: make tests pass when localhost resolves to ::1
fix: replace usage of
new Buffer()chore: add
'use strict'directiveschore(deps): update ip-address to 9.x
chore: add github workflows
chore: drop yarn, use npm instead
chore: rename package to mongodb-js prefix