Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6328): pass through optional options in txn APIs #45

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

nbbeeken
Copy link
Collaborator

@nbbeeken nbbeeken commented Aug 13, 2024

Description

What is changing?

  • Add optional options pass through
  • No public API changes
Is there new documentation needed for these changes?

No

What is the motivation for this change?

  • The driver is adding an optional options object to these APIs we need to pass it through to enable it in our tests.

Release Highlight

Internal MongoDB Driver fix

Note

A correction has been made to an API that is only relevant to driver internals. There are no public-facing API changes in this fix.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review August 13, 2024 20:28
@W-A-James W-A-James self-assigned this Aug 14, 2024
@W-A-James W-A-James self-requested a review August 14, 2024 15:17
@W-A-James W-A-James merged commit bacf3cf into main Aug 14, 2024
8 checks passed
@W-A-James W-A-James deleted the NODE-6328-add-options-argument-session-txn branch August 14, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants