Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compass-validation): unified validation preview CTA COMPASS-8862 #6769

Merged
merged 6 commits into from
Mar 6, 2025

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Mar 4, 2025

Description

This one is independent and so it's not behind the feature toggle.

CTA:
Screenshot 2025-03-05 at 12 41 17
Samples:
Screenshot 2025-03-05 at 12 41 04

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Mar 4, 2025
@paula-stacho paula-stacho marked this pull request as ready for review March 5, 2025 12:05
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

<InlineDefinition definition={SAMPLE_DEFINITION}>
Sample documents
Preview your sample here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview your sample here reads a bit funny to me. Maybe Preview sample documents?
Not a blocker, fine as is.

@paula-stacho paula-stacho changed the title fix(compass-validation): unified preview CTA COMPASS-8862 fix(compass-validation): unified validation preview CTA COMPASS-8862 Mar 6, 2025
@paula-stacho paula-stacho merged commit 90c1998 into main Mar 6, 2025
57 checks passed
@paula-stacho paula-stacho deleted the COMPASS-8862 branch March 6, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants