Fixing nil pointer reference.

pkg/controller/controller.go

@@ -137,6 +137,8 @@ func (c *Controller) RegisterRoutes(app *iris.Application) {
 		})
 	}
 
+	app.Get("/health", c.getHealth)
+
 	app.Use(func(ctx iris.Context) {
 		log := c.log.WithFields(logrus.Fields{
 			"requestId": ctx.GetHeader("X-Request-Id"),
@@ -148,8 +150,6 @@ func (c *Controller) RegisterRoutes(app *iris.Application) {
 	})
 
 	app.PartyFunc(APIPath, func(p router.Party) {
-		p.Get("/health", c.getHealth)
-
 		p.Use(c.loggingMiddleware)
 		p.OnAnyErrorCode(func(ctx iris.Context) {
 			if err := ctx.GetErr(); err != nil {

pkg/internal/myownsanity/strings.go

@@ -31,6 +31,9 @@ func StringPEqual(a, b *string) bool {
 	if a != nil && b == nil {
 		return false
 	}
+	if a == nil && b == nil {
+		return true
+	}
 
 	return *a == *b
 }

pkg/internal/myownsanity/strings_test.go

@@ -59,4 +59,6 @@ func TestStringPEqual(t *testing.T) {
 		b := "b"
 		assert.False(t, StringPEqual(nil, &b), "should not be equal")
 	}
+
+	assert.True(t, StringPEqual(nil, nil), "should be equal")
 }

pkg/jobs/pull_latest_transactions.go

@@ -168,8 +168,6 @@ func (j *jobManagerBase) pullLatestTransactions(job *work.Job) (err error) {
 			plaidIdsToBankIds[bankAccount.PlaidAccountId] = bankAccount.BankAccountId
 		}
 
-		log.Debugf("retrieving transactions for %d bank account(s)", len(itemBankAccountIds))
-
 		// Request the last 7 days worth of transactions for update.
 		start := time.Now().Add(-7 * 24 * time.Hour)
 		if link.LastSuccessfulUpdate == nil {
@@ -188,12 +186,15 @@ func (j *jobManagerBase) pullLatestTransactions(job *work.Job) (err error) {
 			return err
 		}
 
+		log.Debugf("retrieving transactions for %d bank account(s)", len(itemBankAccountIds))
 		transactions, err := platypus.GetAllTransactions(span.Context(), start, end, itemBankAccountIds)
 		if err != nil {
 			log.WithError(err).Error("failed to retrieve transactions from plaid")
 			return errors.Wrap(err, "failed to retrieve transactions from plaid")
 		}
 
+		log.Debugf("retrieved %d transactions", len(transactions))
+
 		if err = j.upsertTransactions(
 			span.Context(),
 			log,

pkg/jobs/transactions.go

@@ -46,6 +46,8 @@ func (j *jobManagerBase) upsertTransactions(
 		return err
 	}
 
+	log.Debugf("found %d existing transactions", len(transactionsByPlaidId))
+
 	transactionsToUpdate := make([]*models.Transaction, 0)
 	transactionsToInsert := make([]models.Transaction, 0)
 	now := time.Now().UTC()