-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copyright: bump to 2025 #9666
base: master
Are you sure you want to change the base?
copyright: bump to 2025 #9666
Conversation
I wanted to mention that I've seen other projects change their copyright headers in source files to See e.g.: https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/txorphan.cpp#L1 |
As the topic of annual, noisy commits has yet again reared its head, I suggest seriously considering #8698 (comment) |
I agree with @iamamyth. NACK large automated copyright year changes without any real legal justification |
Here are some examples of what big corporations with lawyers who ought to know about this stuff have come up with:
Facebook has used In the interest of avoiding force-pushes due to forgotten copyright header updates (which waste dev time and CI runs) and not making life any more difficult for new contributors, I heavily favor any option that does not involve manually updating copyright headers. |
I think omitting the year in source files and referring to the LICENSE file is the least cumbersome approach. Some variations:
|
In my opinion, which is not and should not be construed as legal advice, the first variation seems the most intelligible, and also most closely matches the Linux license seen here: https://github.com/torvalds/linux/blob/master/kernel/cgroup/cgroup.c. Crucially, like with Linux, there are files in this project which have multiple sources, each with their own copyright, so an auto-change tool needs take care not to drop information. As a bonus, referencing a single license file will clean up the spaces at EOL in the existing template, which anger my editor and offend all principles of computer science. |
Happy new year! 😺