Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyright: bump to 2025 #9666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

plowsof
Copy link
Contributor

@plowsof plowsof commented Jan 1, 2025

Happy new year! 😺

From an external runflow @ https://github.com/plowsof/copyCat/actions/runs/12565549101

@tobtoht
Copy link
Collaborator

tobtoht commented Jan 2, 2025

I wanted to mention that I've seen other projects change their copyright headers in source files to <YEAR>-present. This way they don't have to be updated annually.

See e.g.: https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/txorphan.cpp#L1

@iamamyth
Copy link

iamamyth commented Jan 9, 2025

As the topic of annual, noisy commits has yet again reared its head, I suggest seriously considering #8698 (comment)

@jeffro256
Copy link
Contributor

I agree with @iamamyth. NACK large automated copyright year changes without any real legal justification

@tobtoht
Copy link
Collaborator

tobtoht commented Feb 14, 2025

Here are some examples of what big corporations with lawyers who ought to know about this stuff have come up with:

Facebook has used <year> - present in the past, but no longer follows this practice, suggesting this might not be a 'valid' legal option, see also.

In the interest of avoiding force-pushes due to forgotten copyright header updates (which waste dev time and CI runs) and not making life any more difficult for new contributors, I heavily favor any option that does not involve manually updating copyright headers.

@tobtoht
Copy link
Collaborator

tobtoht commented Feb 14, 2025

I think omitting the year in source files and referring to the LICENSE file is the least cumbersome approach.

Some variations:

// Copyright (c) The Monero Project
//
// This source code is licensed under the BSD-3 license found in the
// LICENSE file in the root directory of this source tree.
// Copyright (c) The Monero Project
// Licensed under the BSD-3 License. See LICENSE in the project root for license information.
// Copyright (c) The Monero Project
// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file. 
// Copyright (c) The Monero Project
// Distributed under the BSD-3 software license, see the accompanying file LICENSE.
// This file is part of The Monero Project which is released under BSD-3.
// See file LICENSE for full license details.

@iamamyth
Copy link

In my opinion, which is not and should not be construed as legal advice, the first variation seems the most intelligible, and also most closely matches the Linux license seen here: https://github.com/torvalds/linux/blob/master/kernel/cgroup/cgroup.c. Crucially, like with Linux, there are files in this project which have multiple sources, each with their own copyright, so an auto-change tool needs take care not to drop information. As a bonus, referencing a single license file will clean up the spaces at EOL in the existing template, which anger my editor and offend all principles of computer science.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants