src: dynamic block sync size #9494
Open
+76
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFFFC0000
force-pushed
the
dev/0xfffc/dynamic-bss
branch
from
5b05971 to
ce38fde
Compare
|
Same content. Only removed white-space changes. |
nahuhh
approved these changes
Oct 1, 2024
0xFFFC0000
force-pushed
the
dev/0xfffc/dynamic-bss
branch
from
ce38fde to
2ce35d9
Compare
sneurlax
approved these changes
Oct 2, 2024
vtnerd
suggested changes
Oct 9, 2024
nahuhh
reviewed
Oct 11, 2024
0xFFFC0000
force-pushed
the
dev/0xfffc/dynamic-bss
branch
from
2ce35d9 to
03d0dce
Compare
|
All comments have been addressed. Once discussion finished, I will update |
0xFFFC0000
force-pushed
the
dev/0xfffc/dynamic-bss
branch
from
03d0dce to
2195b6a
Compare
|
Updated to most latest |
Co-authored-by: nahuhh
0xFFFC0000
force-pushed
the
dev/0xfffc/dynamic-bss
branch
from
2195b6a to
5459934
Compare
|
Rebased to updated master. Now CI should run without any issue. |
nahuhh
suggested changes
Feb 21, 2025
| MINFO("Last " << number_of_blocks | ||
| << " blocks median size is " << median_weight | ||
| << " bytes and the max average blocksize in the queue is " << average_blocksize_of_biggest_batch << " bytes"); | ||
| uint64_t projected_blocksize = (average_blocksize_of_biggest_batch > median_weight) ? average_blocksize_of_biggest_batch : median_weight; |
There was a problem hiding this comment.
Suggested change
| uint64_t projected_blocksize = (average_blocksize_of_biggest_batch > median_weight) ? average_blocksize_of_biggest_batch : median_weight; | |
| uint64_t projected_blocksize = (average_blocksize_of_biggest_batch > median_weight) ? average_blocksize_of_biggest_batch : median_weight; | |
| uint64_t blocks_huge_threshold = (batch_max_weight / 2); |
Comment on lines
1252
to
1258
| else if (projected_blocksize >= batch_max_weight) { | ||
| res = 1; | ||
| MINFO("blocks are projected to surpass " << batch_max_weight << " bytes, syncing just a single block in next batch"); | ||
| } | ||
| else if (projected_blocksize > BLOCKS_HUGE_THRESHOLD_SIZE) { | ||
| res = 1; | ||
| MINFO("blocks are huge, sync just a single block in next batch"); |
There was a problem hiding this comment.
Suggested change
| else if (projected_blocksize >= batch_max_weight) { | |
| res = 1; | |
| MINFO("blocks are projected to surpass " << batch_max_weight << " bytes, syncing just a single block in next batch"); | |
| } | |
| else if (projected_blocksize > BLOCKS_HUGE_THRESHOLD_SIZE) { | |
| res = 1; | |
| MINFO("blocks are huge, sync just a single block in next batch"); | |
| else if (projected_blocksize >= blocks_huge_threshold) { | |
| res = 1; | |
| MINFO("blocks are projected to surpass 50% of " << batch_max_weight << " bytes, syncing just a single block in next batch"); | |
| } |
condense
src/cryptonote_config.h
Outdated
| #define BLOCKS_MEDIAN_WINDOW 100 //by default, compute median weights of last 100 blocks | ||
| #define BATCH_MAX_WEIGHT 20 //by default, maximum size of batch in [mB] | ||
| #define BATCH_MAX_ALLOWED_WEIGHT 50 //maximum allowed size of batch in [mB] | ||
| #define BLOCKS_HUGE_THRESHOLD_SIZE ((BATCH_MAX_WEIGHT * 1000000) / 2) //blocks that we consider huge [B] |
There was a problem hiding this comment.
Suggested change
| #define BLOCKS_HUGE_THRESHOLD_SIZE ((BATCH_MAX_WEIGHT * 1000000) / 2) //blocks that we consider huge [B] |
swapped here
#9494 (comment)
src/cryptonote_config.h
Outdated
| @@ -98,6 +98,10 @@ | |||
| #define BLOCKS_SYNCHRONIZING_DEFAULT_COUNT_PRE_V4 100 //by default, blocks count in blocks downloading | |||
| #define BLOCKS_SYNCHRONIZING_DEFAULT_COUNT 20 //by default, blocks count in blocks downloading | |||
| #define BLOCKS_SYNCHRONIZING_MAX_COUNT 2048 //must be a power of 2, greater than 128, equal to SEEDHASH_EPOCH_BLOCKS | |||
| #define BLOCKS_MEDIAN_WINDOW 100 //by default, compute median weights of last 100 blocks | |||
There was a problem hiding this comment.
Suggested change
| #define BLOCKS_MEDIAN_WINDOW 100 //by default, compute median weights of last 100 blocks | |
| #define BLOCKS_MEDIAN_WINDOW CRYPTONOTE_REWARD_BLOCKS_WINDOW //by default, compute median weights of last 100 blocks (CRYPTONOTE_REWARD_BLOCKS_WINDOW) |
nahuhh
reviewed
Feb 21, 2025
| @@ -112,6 +113,15 @@ namespace cryptonote | |||
| void log_connections(); | |||
| std::list<connection_info> get_connections(); | |||
| const block_queue &get_block_queue() const { return m_block_queue; } | |||
| const std::uint64_t max_average_of_blocksize_in_queue() { | |||
There was a problem hiding this comment.
Suggested change
| const std::uint64_t max_average_of_blocksize_in_queue() { | |
| std::uint64_t max_average_of_blocksize_in_queue() { |
Warning in build log
0xFFFC0000
force-pushed
the
dev/0xfffc/dynamic-bss
branch
3 times, most recently
from
6315667 to
03bcd6f
Compare
Co-authored-by: nahuhh
0xFFFC0000
force-pushed
the
dev/0xfffc/dynamic-bss
branch
from
03bcd6f to
fd06f00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.