Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates aws.account.id resource #4020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updates aws.account.id resource #4020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/aws/resources/aws_account.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
)

func (a *mqlAwsAccount) id() (string, error) {
return "aws.account/" + a.Id.Data, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a heads up, there are a couple other adjustments around discovery that we will need to do if this change goes in

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change feels worth it IMO. The old output didn't really make sense. This output is better for asset inventory and customer usage. We should definitely understand the impact of this breaking change though anywhere else in the product.

return a.Id.Data, nil
}

func (a *mqlAwsAccount) aliases() ([]interface{}, error) {
Expand Down
Loading