Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update away from deprecated GitLab field #3924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update away from deprecated GitLab field #3924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/gitlab/resources/gitlab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func initGitlabGroup(runtime *plugin.Runtime, args map[string]*llx.RawData) (map
args["requireTwoFactorAuthentication"] = llx.BoolData(grp.RequireTwoFactorAuth)
args["preventForkingOutsideGroup"] = llx.BoolData(grp.PreventForkingOutsideGroup)
args["mentionsDisabled"] = llx.BoolData(grp.MentionsDisabled)
args["emailsDisabled"] = llx.BoolData(grp.EmailsDisabled)
args["emailsDisabled"] = llx.BoolData(!grp.EmailsEnabled)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add the new field and mark the old one as deprecated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to just update the call under the hood and keep our fields the same. I don't think we need to match our fields to their underlying API 1:1 in every case. The fields are named pretty consistently which is nice and it wouldn't benefit the user to switch them unless they remove all the "disabled" calls in the future.


return args, nil, nil
}
Expand Down
Loading