Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build - Sep 2024 files #651

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Build - Sep 2024 files #651

merged 1 commit into from
Sep 9, 2024

Conversation

twhetzel
Copy link
Contributor

@twhetzel twhetzel commented Sep 7, 2024

Resolves #ISSUE(s).

Overview

This PR:

  • Full build files for September Lexical Alignment review
    NOTE: No new changes from develop are included in main for this PR for this month's build to create lexical alignment files.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

  • Yes
  • No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after
docker pull obolibrary/odkfull:dev), and no errors occurred?

  • Yes
  • No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

  • Yes

@twhetzel twhetzel requested a review from joeflack4 September 7, 2024 14:15
@twhetzel twhetzel self-assigned this Sep 7, 2024
Copy link
Contributor

@joeflack4 joeflack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just some observations of some things that changed more than others, but all seems normal to me.

  • DOID: Plenty new in lexmatch, mapping status, 60~ new in component signature.
  • Orphanet: 80 new in ordo-subsets.robot.tsv, 70 less entries in unmapped. Most entries in mondo_closematch_orphanet.tsv gone now (this one, I'm not really sure why).
  • unmapped_icd11foundation_lex_exact.tsv: Previously empty; now has rows!
  • OMIM: lexmatch, I see label changes, and many new match entries to NCBI or HGNC genes. This correspond to component_signature-omim.tsv, with 3.5k more lines, almost completely due to new HGNC entries. Expected / fair amount of new entries to mapping status and slurp.

@twhetzel twhetzel merged commit 52ca8e8 into main Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants