-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional phenogrid fixes #943
Conversation
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 70.75% 70.97% +0.21%
==========================================
Files 91 91
Lines 3084 3128 +44
==========================================
+ Hits 2182 2220 +38
- Misses 902 908 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patrick walked me through these. Looks good.
Hi @ptgolden, thanks for pushing these changes! As for the The label inside the tooltip is in bold 👍 but the label on the y-axis prints the Not sure if this is something on my side, but I thought I should let you know before the release this week. |
Oh shoot- let me fix that. |
@dpavam this was a little more involved than I thought, but the fix is in the PR I just made |
Allow
<b>
tags in node labels (including phenogrid labels), and add appropriate keys for phenogrid row/column tooltips.