Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spacy dependancy in pyproject.toml #920

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

ptgolden
Copy link
Member

Copied from #913 from @madanucd

Related issues

Summary

This PR addresses dependency issues with monarch-py deployment to PyPI, fixing errors caused by direct dependencies on external URLs for spacy en_core_sci_sm model.

  • Utilized pystow to download and cache the en_core_sci_sm model from an S3 URL.

  • Implemented automatic unpacking and dynamic directory identification to ensure the model is properly extracted and loaded.

Checks

  • All annotation backend tests were checked and successfully passed.
  • Completed testing of the API development environment to ensure proper integration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 5193daf
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/67588017929ca70008a9be83
😎 Deploy Preview https://deploy-preview-920--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.26%. Comparing base (af5ab7b) to head (5193daf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   71.14%   71.26%   +0.11%     
==========================================
  Files          91       91              
  Lines        3136     3149      +13     
==========================================
+ Hits         2231     2244      +13     
  Misses        905      905              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinschaper kevinschaper merged commit 807a611 into main Dec 13, 2024
11 checks passed
@kevinschaper kevinschaper deleted the issue-890-dependency-update-cherry-picked branch December 13, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacy git dependency breaks pypi deploy
3 participants