-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add faceting/filtering to association endpoints #786
Conversation
…r association api endpoint & association table on nodes
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
+ Coverage 71.30% 71.37% +0.07%
==========================================
Files 91 91
Lines 3136 3148 +12
==========================================
+ Hits 2236 2247 +11
- Misses 900 901 +1 ☔ View full report in Codecov by Sentry. |
This adds facet_fields, facet_fields and filter_queries to the external api endpoints and internal python api functions, along with the necessary data model changes. Plus, of course, a big dump of fixture changes to go with it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I did notice Codecov flagged one line as not having test coverage, but it doesn't seem like a big deal.
Updates association endpoints to allow facet field, facet query and (open) filter query params