Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faceting/filtering to association endpoints #786

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

kevinschaper
Copy link
Member

Updates association endpoints to allow facet field, facet query and (open) filter query params

…r association api endpoint & association table on nodes
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 5734be2
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/672d5adbdcd7480008159fc0
😎 Deploy Preview https://deploy-preview-786--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kevinschaper kevinschaper linked an issue Nov 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.37%. Comparing base (714b664) to head (5734be2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...onarch_py/implementations/solr/solr_query_utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
+ Coverage   71.30%   71.37%   +0.07%     
==========================================
  Files          91       91              
  Lines        3136     3148      +12     
==========================================
+ Hits         2236     2247      +11     
- Misses        900      901       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinschaper
Copy link
Member Author

This adds facet_fields, facet_fields and filter_queries to the external api endpoints and internal python api functions, along with the necessary data model changes. Plus, of course, a big dump of fixture changes to go with it

Copy link
Collaborator

@amc-corey-cox amc-corey-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I did notice Codecov flagged one line as not having test coverage, but it doesn't seem like a big deal.

@kevinschaper kevinschaper merged commit ce0851b into main Nov 15, 2024
11 checks passed
@kevinschaper kevinschaper deleted the association-facets branch November 15, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of models by species
2 participants