Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip delete SSH keys when none are present #540

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Skip delete SSH keys when none are present #540

merged 1 commit into from
Jan 16, 2024

Conversation

glass-ships
Copy link
Collaborator

Resolves issue with deleting GCP ssh keys if none are there

@netlify Netlify
Copy link

netlify bot commented Jan 16, 2024

✅ Deploy Preview for monarch-app canceled.

Name Link
🔨 Latest commit ebd13d4
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/65a7032af29cba00089a8264

@amc-corey-cox amc-corey-cox self-requested a review January 16, 2024 22:29
amc-corey-cox
amc-corey-cox approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@amc-corey-cox amc-corey-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this and Glass took a look. This should prevent the error when trying to remove SSH keys by skipping removal when no keys exist.

@glass-ships glass-ships merged commit 28ab311 into main Jan 16, 2024
10 checks passed
@glass-ships glass-ships deleted the fix_del_keys branch January 16, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amc-corey-cox amc-corey-cox amc-corey-cox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glass-ships @amc-corey-cox