Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed text that links to HPO #455

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Fixed text that links to HPO #455

merged 3 commits into from
Nov 29, 2023

Conversation

nlharris
Copy link
Member

The text on https://monarchinitiative.org/phenomics-first linking to HPO said "The The Phenomics First Resource"; changed it to "The Human Phenotype Ontology".

Made a few other minor edits for clarity and correctness (e.g., Peter likes it to be called "The Phenopacket schema", not "Phenopackets"). The Phenopackets text could use some additional updating, I think, but I didn't attempt to do that.

I also noticed that there's a "Coming Soon" note lower down on the page under Phenopackets, but Phenopackets are covered higher on the page.

The text linking to HPO said "The The Phenomics First Resource"; changed it to "The Human Phenotype Ontology".

Made a few other minor edits for clarity and correctness (e.g., Peter likes it to be called "The Phenopacket schema", not "Phenopackets"). The Phenopackets text could use some additional updating, I think, but I didn't attempt to do that.

I also noticed that there's a "Coming Soon" note lower down on the page under Phenopackets, but Phenopackets are covered higher on the page.
@nlharris nlharris requested a review from glass-ships October 31, 2023 04:33
@netlify
Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 876e4c1
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/6567bc7b2f9ddd0008517a6f
😎 Deploy Preview https://deploy-preview-455--monarch-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincerubinetti
Copy link
Contributor

Is this still relevant? Maybe Glass pulled it into one of the other PRs they had open? Need to run yarn lint to fix test. Or possibly can format right from .dev (press . on this page) with the default VS Code format document function.

@nlharris
Copy link
Member Author

I'm not sure, but https://monarchinitiative.org/phenomics-first still has the old unfixed content (search for "The the").

Copy link
Collaborator

@glass-ships glass-ships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! sorry it took me a bit to get around to this

@glass-ships glass-ships merged commit 4d99af0 into main Nov 29, 2023
9 checks passed
@glass-ships glass-ships deleted the nlharris-patch-1 branch November 29, 2023 22:40
@nlharris
Copy link
Member Author

How long does it take for the fixes to propagate to the live site?

@glass-ships
Copy link
Collaborator

That currently requires a manual deployment of the new images to Google Cloud - unfortunately @kevinschaper is the most familiar with that process and is away on vacation until next week, but I plan to meet with him to document that process, so we'll look to getting the live site updated at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants