-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed text that links to HPO #455
Conversation
The text linking to HPO said "The The Phenomics First Resource"; changed it to "The Human Phenotype Ontology". Made a few other minor edits for clarity and correctness (e.g., Peter likes it to be called "The Phenopacket schema", not "Phenopackets"). The Phenopackets text could use some additional updating, I think, but I didn't attempt to do that. I also noticed that there's a "Coming Soon" note lower down on the page under Phenopackets, but Phenopackets are covered higher on the page.
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Is this still relevant? Maybe Glass pulled it into one of the other PRs they had open? Need to run |
I'm not sure, but https://monarchinitiative.org/phenomics-first still has the old unfixed content (search for "The the"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! sorry it took me a bit to get around to this
How long does it take for the fixes to propagate to the live site? |
That currently requires a manual deployment of the new images to Google Cloud - unfortunately @kevinschaper is the most familiar with that process and is away on vacation until next week, but I plan to meet with him to document that process, so we'll look to getting the live site updated at that time. |
The text on https://monarchinitiative.org/phenomics-first linking to HPO said "The The Phenomics First Resource"; changed it to "The Human Phenotype Ontology".
Made a few other minor edits for clarity and correctness (e.g., Peter likes it to be called "The Phenopacket schema", not "Phenopackets"). The Phenopackets text could use some additional updating, I think, but I didn't attempt to do that.
I also noticed that there's a "Coming Soon" note lower down on the page under Phenopackets, but Phenopackets are covered higher on the page.